Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Small changes in metadata bar copy and tooltip placement #21952

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

3 small changes in metadata bar in Explore:

  1. Instead of displaying "Added to X dashboard(s)", we display "Added to 1 dashboard" or "Added to 2 dashboards" (singular vs plural)
  2. Copy fix - changed "You can preview the list of dashboards on the chart settings dropdown." to "You can preview the list of dashboards in the chart settings dropdown." (prev - "on", now - "in")
  3. Forced the tooltip to always render at the bottom. Before, all tooltips rendered at the bottom of metadata bar except for "Not added to any dashboard" which was inconsistent.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

image

After:

image

image

image

TESTING INSTRUCTIONS

Check metadata bars of charts added to 0, 1 and more than 1 dashboards

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

@kasiazjc
Copy link
Contributor

LGTM, thank you! 🙏

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #21952 (71c6322) into master (7600da8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21952      +/-   ##
==========================================
- Coverage   66.95%   66.95%   -0.01%     
==========================================
  Files        1807     1807              
  Lines       69196    69190       -6     
  Branches     7402     7399       -3     
==========================================
- Hits        46331    46324       -7     
- Misses      20954    20957       +3     
+ Partials     1911     1909       -2     
Flag Coverage Δ
javascript 53.37% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 82.71% <100.00%> (ø)
...rontend/src/components/MetadataBar/MetadataBar.tsx 98.21% <100.00%> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx 55.76% <100.00%> (ø)
...ashboard/components/BuilderComponentPane/index.tsx 66.66% <0.00%> (-9.81%) ⬇️
...t-frontend/src/dashboard/components/SliceAdder.jsx 60.27% <0.00%> (-2.40%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 58.99% <0.00%> (-0.87%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 62.85% <0.00%> (-0.20%) ⬇️
...erset-frontend/src/components/Chart/chartAction.js 56.77% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <0.00%> (ø)
...et-ui-core/src/connection/callApi/parseResponse.ts 100.00% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -274,7 +274,7 @@ export default function DrillDetailPane({
: [notAvailable];
items.push({
type: MetadataType.TABLE,
title: table_name,
title: 'dscsdjnvsjkdvnsdjvnsjdvnjsdnvhjsdknbvhjksdv',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 🤣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

@kgabryje kgabryje force-pushed the fix/metadata-bar-copy branch from ede6d0b to 71c6322 Compare October 27, 2022 18:52
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements!

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 3c7a081 into apache:master Oct 28, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.0 v2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants