fix: add form data for empty state control to save dataset #21944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
approved these changes
Oct 28, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There is an issue where if a user tries to save the dataset from the time control, when user power charts from query, user will be shown an error of missing params. This was because of the potential for the database info to be structured different from the original object structure.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
Screen.Recording.2022-10-27.at.12.27.34.PM.mov
TESTING INSTRUCTIONS
Run a sql query in sql lab that has no temporal columns
Create a chart with the query powering the chart
In the Time section, click the blank state button to create a dataset
ADDITIONAL INFORMATION