fix(database): Handle String errors in DatabaseModal #21709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Showing string errors not only object ones - Add tests that cover error display
Antonio-RiveroMartnez
changed the title
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://34.217.194.45:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #21709 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 1799 1799
Lines 68875 68877 +2
Branches 7319 7320 +1
=======================================
+ Hits 46044 46051 +7
+ Misses 20944 20937 -7
- Partials 1887 1889 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hughhhh
approved these changes
Oct 6, 2022
eschutho
approved these changes
Oct 6, 2022
AnushaErrabelli
pushed a commit
to preset-io/superset
that referenced
this pull request
Oct 6, 2022
(cherry picked from commit 97273f5)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
At some point we stopped handling and displaying API errors coming as raw strings in the DatabaseModal. We are bringing that back, so for example, if someone tries to connect a BigQuery DB using credential JSON files with no roles in it, an error gets displayed vs no indication at all.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
Create a new Service Account on Google Console. Doesn’t grant any Role to it.
Download the Service Account key via jSON.
Access your Workspace.
Hover over the + on the top right corner, then navigate to Data > Connect database.
Select Google BigQuery.
Click on Choose File to upload the JSON.
Click on CONNECT.
ADDITIONAL INFORMATION