Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Right-click on misconfigured World Map #21697

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug that happens when a user right-clicks on a World Map chart that has an invalid configuration in the Country Column or Country Field Type. Examples of invalid configuration would be assigning a region/number/etc to the Country Column or choosing the wrong Country Field Type formatting.

@codyml

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-10-03 at 6 48 24 PM

Screen Shot 2022-10-04 at 1 56 21 PM

TESTING INSTRUCTIONS

Check that instead of throwing an error, the application shows a warning for invalid World Map configurations.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 4, 2022

Codecov Report

Merging #21697 (0aca1b5) into master (2907869) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #21697      +/-   ##
==========================================
- Coverage   66.84%   66.83%   -0.01%     
==========================================
  Files        1799     1799              
  Lines       68870    68873       +3     
  Branches     7314     7314              
==========================================
  Hits        46034    46034              
- Misses      20954    20957       +3     
  Partials     1882     1882              
Flag Coverage Δ
javascript 53.13% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 770f68f into apache:master Oct 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants