fix(superset-embedded-sdk): Buffer is not defined

[doornot]

Buffer is a Nodejs api, doesn't support in the browser environment. Replace Buffer with jwt-decode to parse Jwt.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[doornot]

hello @villebro, please help review.

BTW, if this pr be approved and merged, will CI publish @superset-ui/embedded-sdk automatically?

[villebro]

LGTM, but not sure if we should bump the version in this PR. Also, I'm wondering if we should include this library in monorepo - WDYT @zhaoyongjie ?

[villebro]

I think it's best not to bump this in this PR, but rather when the package is published. WDYT @zhaoyongjie ?

[zhaoyongjie]

@doornot Could you revert this change and package-lock.json so that I can merge it even if CI reports that issue?

[doornot]

Ok, thanks @zhaoyongjie

[zhaoyongjie]

Codes LGTM, the browser supported ArrayBuffer rather than Buffer.

Right now, the frontend code has 3 parts, superset-frontend, superset-embedded-sdk, and superset-websocket. In order to auto-publish these, Moving to the monorepo might be a good idea.

[doornot]

I would like to know how can i fix the failed merge check("Welcome New Contributor / welcome (pull_request_target)")? @zhaoyongjie @villebro

[andrey-hohlov]

Any chance to get new release with these changes?

[villebro]

Any chance to get new release with these changes?

@andrey-hohlov that's a good idea. In the future new versions should be released when new versions come out, but for now I think we should be able to do a manual release to make the most recent changes available. @zhaoyongjie have you done releases to the embedded SDK lately? If not I can take a stab at it..

[zhaoyongjie]

@villebro I haven't touch embedded SDK recently.

[aehanno]

Hi ! Do you know when there will be a release with this bug ?

[erik-squared]

any chance there will be a new release in the near future? if not, is there a workaround for a browser environment?

[andrey-hohlov]

any chance there will be a new release in the near future? if not, is there a workaround for a browser environment?

@eduus710 we use this for now:

https://www.npmjs.com/package/buffer

import { Buffer } from 'buffer';

window.Buffer = Buffer;

[villebro]

FYI I will try to push a new version of the SDK out today, I will keep you posted.

[villebro]

Can you check if this is working as expected? https://www.npmjs.com/package/@superset-ui/embedded-sdk/v/0.1.0-alpha.8 (switchboard also published: https://www.npmjs.com/package/@superset-ui/switchboard/v/0.18.26-1)

[erik-squared]

thank you!

(fyi - i grabbed the bundle from npm; however, i notice that unpkg.com is still serving alpha 7)

[andrey-hohlov]

@villebro Thank you, works for us