-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dep): Unpin slackclient dependency #21586
Conversation
…ccessor slack_sdk with fewer dependencies.
… tabulate dep open-ended.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, that stale Slack library had started to annoy me, too 🙂 Left a few comments, LMKWYT.
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
Tagging @dpgaspar and @bkyryliuk for additional reviews to validate for potential regressions caused by the Slack client major bump. |
Codecov Report
@@ Coverage Diff @@
## master #21586 +/- ##
==========================================
- Coverage 66.65% 65.22% -1.44%
==========================================
Files 1794 1794
Lines 68721 68713 -8
Branches 7318 7312 -6
==========================================
- Hits 45804 44816 -988
- Misses 21055 22029 +974
- Partials 1862 1868 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one last optional comment
Co-authored-by: Ville Brofeldt <[email protected]>
Ping @dpgaspar @bkyryliuk Does anything need fixing in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that charts are sent to Slack with the new sdk
SUMMARY
This is the last of three PRs, attempting to unpin Superset dependencies. See also #21581 and #21091
slackclient
was originally pinned in #10345 due to slackapi/python-slack-sdk#728 which was fixed in a series of PRs concluding with slackapi/python-slack-sdk#901 which was released inslack_sdk
version 3.1.1.slack_sdk
no longer depends onaiohttp
, which removes a handful of dependencies.While here, make
tabulate
andholidays
dependency versions open-ended. This leaves onlynumpy
pinned ininstall_requires
in setup.py.