Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): Unpin slackclient dependency #21586

Merged
merged 7 commits into from
Oct 4, 2022
Merged

chore(dep): Unpin slackclient dependency #21586

merged 7 commits into from
Oct 4, 2022

Conversation

ecederstrand
Copy link
Contributor

@ecederstrand ecederstrand commented Sep 26, 2022

SUMMARY

This is the last of three PRs, attempting to unpin Superset dependencies. See also #21581 and #21091

slackclient was originally pinned in #10345 due to slackapi/python-slack-sdk#728 which was fixed in a series of PRs concluding with slackapi/python-slack-sdk#901 which was released in slack_sdk version 3.1.1.

slack_sdk no longer depends on aiohttp, which removes a handful of dependencies.

While here, make tabulate and holidays dependency versions open-ended. This leaves only numpy pinned in install_requires in setup.py.

…ccessor slack_sdk with fewer dependencies.
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, that stale Slack library had started to annoy me, too 🙂 Left a few comments, LMKWYT.

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
ecederstrand and others added 2 commits September 26, 2022 12:14
Co-authored-by: Ville Brofeldt <[email protected]>
Co-authored-by: Ville Brofeldt <[email protected]>
@villebro
Copy link
Member

Tagging @dpgaspar and @bkyryliuk for additional reviews to validate for potential regressions caused by the Slack client major bump.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #21586 (a20ef41) into master (954fc89) will decrease coverage by 1.43%.
The diff coverage is 40.00%.

❗ Current head a20ef41 differs from pull request most recent head 3546c50. Consider uploading reports for the commit 3546c50 to get more accurate results

@@            Coverage Diff             @@
##           master   #21586      +/-   ##
==========================================
- Coverage   66.65%   65.22%   -1.44%     
==========================================
  Files        1794     1794              
  Lines       68721    68713       -8     
  Branches     7318     7312       -6     
==========================================
- Hits        45804    44816     -988     
- Misses      21055    22029     +974     
- Partials     1862     1868       +6     
Flag Coverage Δ
hive ?
mysql 78.21% <40.00%> (?)
postgres 78.27% <40.00%> (ø)
presto ?
python 78.40% <40.00%> (-2.91%) ⬇️
sqlite 76.77% <40.00%> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/tasks/slack_util.py 0.00% <0.00%> (ø)
superset/reports/notifications/slack.py 88.00% <100.00%> (ø)
superset/tables/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/columns/schemas.py 0.00% <0.00%> (-100.00%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
... and 63 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last optional comment

setup.py Outdated Show resolved Hide resolved
@ecederstrand
Copy link
Contributor Author

Ping @dpgaspar @bkyryliuk Does anything need fixing in this PR?

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that charts are sent to Slack with the new sdk

@villebro villebro merged commit 6406289 into apache:master Oct 4, 2022
@ecederstrand ecederstrand deleted the bump-slackclient-dep branch October 4, 2022 11:45
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants