-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: optimize docker build by better utilizing build cache #21583
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
@pwang2 Thank you so much for this PR! |
Co-authored-by: EugeneTorap <[email protected]>
Receiving a lot of GitHub Actions failure which I believe should nothing to do with the change here. Can anyone help me figure out if anything missing from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, leave one question for the py_ver
argument in Node section.
# setup.py uses the version information in package.json | ||
COPY superset-frontend/package.json /app/superset-frontend/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO setup.py to read package.json isn't a good idea but exists a long time in Superset, might change this logic in the separated PR.
SUMMARY
Using common docker build practice to use docker build cache better.
New docker image build
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION