Programatically sync the role with user list. #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkyryliuk
changed the title
ascott
reviewed
Nov 17, 2016
| @@ -348,6 +348,50 @@ def test_request_access(self): | |||
| gamma_user.roles.remove(sm.find_role('dummy_role')) | |||
| session.commit() | |||
|
|
|||
| def test_update_role(self): | |||
There was a problem hiding this comment.
is it typical in python to have one test that asserts multiple things? would it make sense to break this into multiple tests?
There was a problem hiding this comment.
+1 on breaking tests down, refactoring shared parts out to methods
ascott
reviewed
Nov 17, 2016
| @has_access | ||
| @expose("/update_role/", methods=['POST']) | ||
| def update_role(self): | ||
| """Assigns a list of found users to the give role.""" |
| for user_email in user_emails: | ||
| user = sm.find_user(email=user_email) | ||
| if not user: | ||
| continue |
There was a problem hiding this comment.
if user:
role.user.append(user)
| return json_error_response( | ||
| __("%(role)s role was not found", role=role_name)) | ||
| role.user = [] | ||
| for user_email in user_emails: |
There was a problem hiding this comment.
for user_email in data['user_emails'] remove the need for 1082
| @@ -1073,6 +1073,27 @@ def msg(self): | |||
|
|
|||
| class Superset(BaseSupersetView): | |||
| """The base views for Superset!""" | |||
|
|
|||
| @has_access | |||
|
LGTM once the build is fixed. |
|
all done, thanks for the review @mistercrunch and @ascott ! |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: