Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keyboard nav & focus in Explore control panel #14575

Closed
wants to merge 6 commits into from

Conversation

GregOnEvo
Copy link

SUMMARY

Provides better keyboard navigation in control panel of Explore view. Allows Label-styled buttons and Checkboxes to focused & interacted with using keyboard. Emulates browser form label click behavior on ControlHeaders: focus, and for Checkboxes, select.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TEST PLAN

Navigate control panel using Tab/Shift-Tab; focus should visibly move in a sensible way.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Keyboard navigation in Explore control panel #14574
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rusackas
Copy link
Member

rusackas commented Aug 1, 2021

Not sure how this slipped under my radar for so long, but I appreciate this effort and will try to take a closer look!

@rusackas
Copy link
Member

rusackas commented Aug 1, 2021

you can run npm run lint-fix in your console to fix the linting errors. The CI run also indicates it needs some TS attention.

@GregOnEvo
Copy link
Author

Thanks for taking a look, should be better now.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 16, 2022
@stale stale bot closed this Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard navigation in Explore control panel
4 participants