-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move styles from .less stylesheet to emotion in Explore #14485
chore: Move styles from .less stylesheet to emotion in Explore #14485
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14485 +/- ##
==========================================
+ Coverage 77.11% 77.12% +0.01%
==========================================
Files 952 953 +1
Lines 48159 48189 +30
Branches 6050 6051 +1
==========================================
+ Hits 37137 37166 +29
- Misses 10821 10822 +1
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
.edit-popover-resize { | ||
transform: scaleX(-1); | ||
-moz-transform: scaleX(-1); | ||
-webkit-transform: scaleX(-1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add all these prefixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, Emotion does it for us. Thanks!
looks like we did some engineering QA before approving and merging this PR, i'm curious to know how the product could be affected in general by migration/refractor PR like this one? how can we better catch regression going forward? |
…e#14485) * Move some styles from .less stylesheet to emotion in Explore * Replace Global styles with local styled components * Address comments
…e#14485) * Move some styles from .less stylesheet to emotion in Explore * Replace Global styles with local styled components * Address comments
…e#14485) * Move some styles from .less stylesheet to emotion in Explore * Replace Global styles with local styled components * Address comments
SUMMARY
This PR moves some styles from
src/explore/main.less
to Emotion. Also, removes.less
stylesheet in native filters - all the styles that we need are in the components.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Manually verify that everything looks as before on explore view and in native filters modal (with 1-2px accuracy caused by using
theme.gridUnit
- for example, 30px margins becametheme.gridUnit * 7
, which equals 28px).ADDITIONAL INFORMATION
CC: @simcha90 @villebro