Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move styles from .less stylesheet to emotion in Explore #14485

Merged
merged 3 commits into from
May 5, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented May 5, 2021

SUMMARY

This PR moves some styles from src/explore/main.less to Emotion. Also, removes .less stylesheet in native filters - all the styles that we need are in the components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

Manually verify that everything looks as before on explore view and in native filters modal (with 1-2px accuracy caused by using theme.gridUnit - for example, 30px margins became theme.gridUnit * 7, which equals 28px).

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC: @simcha90 @villebro

@kgabryje kgabryje changed the title Move some styles from .less stylesheet to emotion in Explore chore: Move styles from .less stylesheet to emotion in Explore May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #14485 (000e1ba) into master (5aef6bc) will increase coverage by 0.01%.
The diff coverage is 90.00%.

❗ Current head 000e1ba differs from pull request most recent head 8be1b53. Consider uploading reports for the commit 8be1b53 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14485      +/-   ##
==========================================
+ Coverage   77.11%   77.12%   +0.01%     
==========================================
  Files         952      953       +1     
  Lines       48159    48189      +30     
  Branches     6050     6051       +1     
==========================================
+ Hits        37137    37166      +29     
- Misses      10821    10822       +1     
  Partials      201      201              
Flag Coverage Δ
javascript 71.94% <88.23%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/chart/chartAction.js 52.70% <0.00%> (-0.27%) ⬇️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 70.23% <ø> (-0.18%) ⬇️
...trol/AdhocFilterEditPopoverSqlTabContent/index.jsx 63.33% <ø> (ø)
superset-frontend/src/explore/controls.jsx 27.16% <0.00%> (ø)
...d/src/explore/components/DatasourcePanel/index.tsx 91.07% <100.00%> (ø)
...d/src/explore/components/ExploreContentPopover.tsx 100.00% <100.00%> (ø)
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 58.06% <100.00%> (ø)
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 69.35% <100.00%> (+4.54%) ⬆️
.../FilterControl/AdhocFilterPopoverTrigger/index.tsx 80.76% <100.00%> (+0.76%) ⬆️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 78.29% <100.00%> (-0.50%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aef6bc...8be1b53. Read the comment docs.

@pull-request-size pull-request-size bot added size/XL and removed size/L labels May 5, 2021
.edit-popover-resize {
transform: scaleX(-1);
-moz-transform: scaleX(-1);
-webkit-transform: scaleX(-1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add all these prefixes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, Emotion does it for us. Thanks!

@kgabryje kgabryje merged commit b030c98 into apache:master May 5, 2021
@junlincc
Copy link
Member

junlincc commented May 8, 2021

looks like we did some engineering QA before approving and merging this PR, i'm curious to know how the product could be affected in general by migration/refractor PR like this one? how can we better catch regression going forward?

@villebro @rusackas @jinghua-qa

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
…e#14485)

* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…e#14485)

* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…e#14485)

* Move some styles from .less stylesheet to emotion in Explore

* Replace Global styles with local styled components

* Address comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants