-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sql-lab] fix react warnings in dev #1232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascott
changed the title
[sql-lab] fix react warnings
[sql-lab] fix react warnings in dev
Oct 3, 2016
Thanks for the fixes! looks good to me. Please wait till @mistercrunch approval, I'm not sure what is the approach we should follow to generate the components ids. |
oh nice, was on my TODO list, thanks for knocking those out! |
This was referenced Aug 19, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat(plugin-chart-pivot-table): multiple improvements * emotion syntax fix
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat(plugin-chart-pivot-table): multiple improvements * emotion syntax fix
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat(plugin-chart-pivot-table): multiple improvements * emotion syntax fix
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat(plugin-chart-pivot-table): multiple improvements * emotion syntax fix
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.11.0
labels
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix react warnings in sql-editor/search, makes it easier to see real errors.
onHide
is invalid;title
was not specified inDropdownButton
id
is required to makeTabs
accessible for users of assistive technologies such as screen readers.id
or agenerateChildId
prop to TabContainer is requiredSqlEditorTopToolbar
. See https://fb.me/react-warning-keys for more information.TableElement
. See https://fb.me/react-warning-keys for more information.@bkyryliuk @mistercrunch @vera-liu