Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql-lab] fix react warnings in dev #1232

Merged
merged 5 commits into from
Oct 4, 2016
Merged

[sql-lab] fix react warnings in dev #1232

merged 5 commits into from
Oct 4, 2016

Conversation

ascott
Copy link
Contributor

@ascott ascott commented Oct 3, 2016

fix react warnings in sql-editor/search, makes it easier to see real errors.

  • Failed prop type: VisualizeModal: prop type onHide is invalid;
  • Failed prop type: Required prop title was not specified in DropdownButton
  • Failed prop type: The prop id is required to make Tabs accessible for users of assistive technologies such as screen readers.
  • Failed prop type: In order to properly initialize Tabs in a way that is accessible to assistive technologies (such as screen readers) an id or a generateChildId prop to TabContainer is required
  • Each child in an array or iterator should have a unique "key" prop. Check the render method of SqlEditorTopToolbar. See https://fb.me/react-warning-keys for more information.
  • Each child in an array or iterator should have a unique "key" prop. Check the render method of TableElement. See https://fb.me/react-warning-keys for more information.

screenshot 2016-10-02 20 59 20

@bkyryliuk @mistercrunch @vera-liu

@ascott ascott changed the title [sql-lab] fix react warnings [sql-lab] fix react warnings in dev Oct 3, 2016
@bkyryliuk
Copy link
Member

Thanks for the fixes! looks good to me. Please wait till @mistercrunch approval, I'm not sure what is the approach we should follow to generate the components ids.

@mistercrunch
Copy link
Member

mistercrunch commented Oct 4, 2016

oh nice, was on my TODO list, thanks for knocking those out!
LGTM

@ascott ascott merged commit ae54ac9 into apache:master Oct 4, 2016
@ascott ascott deleted the alanna-query-history-ui branch October 4, 2016 06:58
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* feat(plugin-chart-pivot-table): multiple improvements

* emotion syntax fix
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* feat(plugin-chart-pivot-table): multiple improvements

* emotion syntax fix
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* feat(plugin-chart-pivot-table): multiple improvements

* emotion syntax fix
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* feat(plugin-chart-pivot-table): multiple improvements

* emotion syntax fix
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants