fix: Filter and Metric popovers not closing after clicking Save

[kgabryje]

SUMMARY

Fixes #11598 and #11608. The issue was that when you opened a popover, didn't make any changes and then clicked save, 'isNew' prop wasn't set to false before sending it to onChange function. Then the component rerendered and isNew was still set to true and popover reopened.
CC: @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue: [Explore]control panel popover can't be saved #11598, [Explore]Control Panel fields dropdown values not showing properly  #11608
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[kgabryje]

@rusackas Can you take a look?

[codecov-io]

Codecov Report

Merging #11607 (615405c) into master (6d5d92a) will decrease coverage by 4.84%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #11607      +/-   ##
==========================================
- Coverage   66.56%   61.72%   -4.85%     
==========================================
  Files         876      878       +2     
  Lines       42172    42264      +92     
  Branches     3949     3948       -1     
==========================================
- Hits        28073    26086    -1987     
- Misses      13996    15996    +2000     
- Partials      103      182      +79     

Flag	Coverage Δ
cypress	?
javascript	62.45% <0.00%> (-0.01%)	⬇️
python	61.27% <ø> (-0.88%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../src/explore/components/AdhocFilterEditPopover.jsx	58.00% <0.00%> (-18.00%)	⬇️
...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx	68.18% <ø> (-16.51%)	⬇️
.../src/explore/components/AdhocMetricEditPopover.jsx	59.74% <ø> (-7.80%)	⬇️
superset-frontend/src/SqlLab/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/App.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/explore/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/dashboard/index.jsx	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/setup/setupColors.js	0.00% <0.00%> (-100.00%)	⬇️
superset-frontend/src/chart/ChartContainer.jsx	0.00% <0.00%> (-100.00%)	⬇️
... and 190 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d5d92a...615405c. Read the comment docs.

[rusackas]

LGTM! I appreciate the tests!

[ktmud]

Thanks for the fix and adding test cases!