Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a saved query in the sql_lab generate the new one instead of overwrite it! #8068

Closed
3 tasks done
blcksrx opened this issue Aug 19, 2019 · 4 comments · Fixed by #8298
Closed
3 tasks done

Editing a saved query in the sql_lab generate the new one instead of overwrite it! #8068

blcksrx opened this issue Aug 19, 2019 · 4 comments · Fixed by #8298
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@blcksrx
Copy link

blcksrx commented Aug 19, 2019

When you want to edit a saved query with sql_lab and when you edit the query and click on the save query button in the sql_lab to save the query, superset makes a new query instead of overwriting the query!
So here is the bug! when I want to edit a saved query and make changes on it, I will get to the Saved Queries pages and I will click on the pop-up link to route the sql_lab to modify the query instead of using the edit button on the saved query page.
why should I or other users do this? here are the reasons:

  1. Users create and develop the queries on the sql_lab page, so when a user wants
    to modify the query the user habit is to modify it on the sql_lab!
  2. Users want to run and test the query when they are modifying it, so the edit page of the saved query is no absolutely sufficient!
  3. sql_lab provides more functionality than the edit the record on the saved queries.

So my approach to solving this issue is that the saved query will be able to modify on the sql_lab, it's simple!

Expected results

overwrite the edited query

Actual results

Create the new record(query)

Screenshots

If applicable, add screenshots to help explain your problem.

How to reproduce the bug

  1. Go to the saved query page.
  2. Click on the pop-up link of any query that you want
  3. modify the query and click on the save query button
  4. See the saved queries page again.

Environment

(please complete the following information):

  • superset version: superset version
  • python version: python --version
  • node.js version: node -v
  • npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.88. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the !deprecated-label:bug Deprecated label - Use #bug instead label Aug 19, 2019
@rubypollev
Copy link

Yeah, this one is quite difficult to work with. Is this a feature or a bug? Hoping it's a bug.

@blcksrx
Copy link
Author

blcksrx commented Sep 25, 2019

I think it's absolutely a bug! and I'm currently waiting for commiters response

@blcksrx
Copy link
Author

blcksrx commented Sep 26, 2019

Thanks! I was waiting for the commiters to approve this issue and then make a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants