Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exploring BQ table throws query error as date is incorrectly formatted #4915

Closed
3 tasks done
kuriancheeramelil opened this issue May 1, 2018 · 2 comments · Fixed by #4918
Closed
3 tasks done

Exploring BQ table throws query error as date is incorrectly formatted #4915

kuriancheeramelil opened this issue May 1, 2018 · 2 comments · Fixed by #4918

Comments

@kuriancheeramelil
Copy link
Contributor

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.25

Expected results

Executing BQ table query via table explore page executes query with date field correctly.

Actual results

the query generated throws syntax error

Steps to reproduce

Add BQ table with date in superset and explore table. Any metric throws syntax error.

The issue seems to be with this line
https://github.com/apache/incubator-superset/blob/e1d2150391ba827a64cebd0c0573aab0a82a3634/superset/db_engine_specs.py#L1263
Instead of
return "'{}'".format(dttm.strftime('%Y-%m-%d'))
it is missing the starting single quote
return "{}'".format(dttm.strftime('%Y-%m-%d'))

mistercrunch added a commit to mistercrunch/superset that referenced this issue May 1, 2018
@mistercrunch
Copy link
Member

Thanks for reporting this, #4918 addresses the issue.

mistercrunch added a commit that referenced this issue May 1, 2018
@kuriancheeramelil
Copy link
Contributor Author

Thank you @mistercrunch.

michellethomas pushed a commit to michellethomas/panoramix that referenced this issue May 24, 2018
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this issue May 31, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this issue Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants