-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exploring BQ table throws query error as date is incorrectly formatted #4915
Comments
mistercrunch
added a commit
to mistercrunch/superset
that referenced
this issue
May 1, 2018
Caused by apache#3847 Fixes apache#4915
Merged
Thanks for reporting this, #4918 addresses the issue. |
mistercrunch
added a commit
that referenced
this issue
May 1, 2018
Thank you @mistercrunch. |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this issue
May 24, 2018
Caused by apache#3847 Fixes apache#4915
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this issue
May 31, 2018
Caused by apache#3847 Fixes apache#4915
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this issue
Nov 16, 2018
Caused by apache#3847 Fixes apache#4915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Make sure these boxes are checked before submitting your issue - thank you!
Superset version
0.25
Expected results
Executing BQ table query via table explore page executes query with date field correctly.
Actual results
the query generated throws syntax error
Steps to reproduce
Add BQ table with date in superset and explore table. Any metric throws syntax error.
The issue seems to be with this line
https://github.com/apache/incubator-superset/blob/e1d2150391ba827a64cebd0c0573aab0a82a3634/superset/db_engine_specs.py#L1263
Instead of
return "'{}'".format(dttm.strftime('%Y-%m-%d'))
it is missing the starting single quote
return "{}'".format(dttm.strftime('%Y-%m-%d'))
The text was updated successfully, but these errors were encountered: