Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up eslint eslint-plugin-prefer-object-spread #3835

Closed
mistercrunch opened this issue Nov 11, 2017 · 2 comments
Closed

Set up eslint eslint-plugin-prefer-object-spread #3835

mistercrunch opened this issue Nov 11, 2017 · 2 comments
Labels
.pinned Draws attention

Comments

@mistercrunch
Copy link
Member

We prefer spread over Object.assign. Looks like there are 162 entries to clean up...

22:07 $ git grep "Object.assign" | wc -l
     162
@mistercrunch mistercrunch mentioned this issue Nov 11, 2017
Merged
@stale
Copy link

stale bot commented May 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 29, 2019
@mistercrunch mistercrunch added the .pinned Draws attention label May 29, 2019
@stale stale bot removed the inactive Inactive for >= 30 days label May 29, 2019
@rsn491
Copy link

rsn491 commented Apr 25, 2020

This issue was tackled in #9466
The remaining 6 Object.assign occurrences at master seem to be compliant with the prefer-object-spread rule.

Should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
.pinned Draws attention
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mistercrunch @rsn491 @junlincc