Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL link to parent or blank does not work within Markup or Separator widget #3672

Closed
3 tasks done
SeanPreusse opened this issue Oct 15, 2017 · 3 comments
Closed
3 tasks done

Comments

@SeanPreusse
Copy link

SeanPreusse commented Oct 15, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

Latest version

Expected results

Link opens new window or within existing

Actual results

Link does not execute
These widgets are helpful in creating an additional context for dashboards and natural flow through.

Steps to reproduce

Code: Link Text

@xrmx
Copy link
Contributor

xrmx commented Oct 15, 2017

What version is latest version? steps to reproduce should contain the procedure to replicate the issue, i don't think clicking a link to google is a superset issue.

@SeanPreusse
Copy link
Author

Version .20.4

Sorry for not being clear. Not sure if the markup slices are intended for this, but it would be great to create a landing page and use the 'markup' slices to navigate to key dashboards. Users can still use the dashboard main page, but the landing page can have other helpful information such as image/icons and a description of the dashboard a user would navigate to.

  1. Create new slice with visualisation type 'Markup'.
  2. Add title, image and url to link to another dashboard, description.
    'Link Text'
  3. Create dashboard with 'markup' widgets navigating to key dashboards
  4. When you click on the link, nothing happens.
    image

@jaylindquist
Copy link

@xrmx PR #3702 opened to fix this. The issue was the iframe was sandboxing and preventing links from opening outside of the iframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants