Bar Values does not reliably work with negative values

[hajdbo]

• I have checked the superset logs for python stacktraces and included it here as text if any
• I have reproduced the issue with at least the latest released version of superset
• I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

master

Expected results

"Bar Values"/addingTotalValues() should display the correct total value on top of stacked bars.

Actual results

"Bar Values"/addingTotalValues() assumes that all data will be positive, and skips negative value bars. This results in totals being displayed on top of the wrong bar.

Steps to reproduce

Stack a mix of positive and negative values. Make sure the last data series is the one that contains at least one negative value.

[hajdbo]

I have a patch which will display only the correct values on the correct bars.

Unsure how the value should be displayed for bars that have negative values, so I skip the value entirely, which is still an improvement over current status.

[xrmx]

Please open a PR then, it's easier to improve working code :)

[hajdbo]

see PR #3366

[mistercrunch]

Notice: this issue has been closed because it has been inactive for 241 days. Feel free to comment and request for this issue to be reopened.