Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ant Design 5: Upgrade Input component #30727

Closed
geido opened this issue Oct 28, 2024 · 3 comments · Fixed by #30730
Closed

Ant Design 5: Upgrade Input component #30727

geido opened this issue Oct 28, 2024 · 3 comments · Fixed by #30730
Assignees
Labels
frontend:refactor:antd5 good first issue Good first issues for new contributors preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.

Comments

@geido
Copy link
Member

geido commented Oct 28, 2024

Please refer to SIP-139 #29268.

The Input component should be upgraded to Ant Design version 5.

Similar work has been completed here.

When upgrading the component to Ant Design 5, please ensure to include:

  • Proper RTL test coverage if not present yet.
  • A Storybook file (if not present) or all necessary changes.
  • Include all relevant component options in the Storybook.
  • Clean up unnecessary custom styles.

When opening a PR:

  • Name your PR refactor({Component}): Upgrade {component} to Ant Design 5
  • Add screenshots of BEFORE/AFTER in your PR.
  • Update the project tracker when your PR is merged.
  • Make sure you or a committer has labeled your PR with frontend:refactor:antd5.
@geido geido added good first issue Good first issues for new contributors preset:bounty Issues that have been selected by Preset and have a bounty attached. preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. labels Oct 28, 2024
@geido
Copy link
Member Author

geido commented Oct 28, 2024


🎉 Preset Bounty Available: $100 USD 🎉

To claim this bounty, please carefully follow the steps below.


📋 Steps to Participate

  1. Review Guidelines:
    Read through the Preset Bounty Program Contribution Guide for complete details on bounty requirements.

  2. Show Your Interest:
    Complete the Preset Bounty Program Survey and comment this issue to express your interest.

  3. Join the Slack Channel:
    After completing the survey, you’ll receive an invitation to the dedicated Apache Superset Slack channel.

  4. Get Assigned:
    To officially start, ensure a Bounty Program Manager has assigned you to this issue.

  5. Submit Your Solution:
    When ready, submit your solution with the Fixes #{issue_number} notation in your Pull Request description.

  6. Claim Your Bounty:
    Sign up at GitPay.me and submit your solution via: https://gitpay.me/#/task/963


💡 Additional Notes

  • Only developers assigned by a Bounty Program Manager should start working on this issue to win the bounty.
  • Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.

Good luck, and happy coding! 🎉

@aybanda
Copy link

aybanda commented Oct 28, 2024

Hey @geido , I would like to work on this issue
can you assign this to me?

@msyavuz
Copy link
Contributor

msyavuz commented Oct 28, 2024

@geido I would like to work on this issue, i already have some work towards this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend:refactor:antd5 good first issue Good first issues for new contributors preset:bounty:chore Chores that have been selected by Preset and have a bounty attached. preset:bounty Issues that have been selected by Preset and have a bounty attached.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@geido @msyavuz @aybanda and others