Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets: unmantained dependency react-alert #2700

Closed
dennybiasiolli opened this issue Apr 30, 2017 · 7 comments
Closed

assets: unmantained dependency react-alert #2700

dennybiasiolli opened this issue Apr 30, 2017 · 7 comments

Comments

@dennybiasiolli
Copy link
Contributor

dennybiasiolli commented Apr 30, 2017

react-alert component's code is unmantained and it uses deprecated code that will be removed in React version 16. (link)

It returns the following warnings during npm test:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
Warning: AsyncCreatableSelect: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

What do you think about fork & update the component in order to avoid deprecation errors when updating to React 16?

@mistercrunch
Copy link
Member

Either forking it or using some equivalent component that is maintained.

@dennybiasiolli
Copy link
Contributor Author

@mistercrunch fork & update in progress (link here).
I'm also trying to contact the author in order to unlock the "no maintenance intended" status

@mistercrunch
Copy link
Member

For you to be able to maintain the package you'll need access to push releases to npm, hopefully the author can grant you that. The main repo is where the work (PRs, issues, ...) should be done, so either you move his repo to your GH org or he grants you admin rights.

@dennybiasiolli
Copy link
Contributor Author

Yes thanks, I'm waiting for a response from @schiehll, the author of the component, in order to have admin rights on the repo or at least on npm package

@dennybiasiolli
Copy link
Contributor Author

Update: the author is working on a v2 of react-alert component, with updated code and dependency. The new version should be compatible with the latest react version without warnings.
As soon as it's released I can test the new version and eventually open a new PR updating the component dependency.

@mistercrunch
Copy link
Member

Awesome. Grateful that you are taking this on!

@dennybiasiolli
Copy link
Contributor Author

Closed by #2923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants