Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating superset frontend on production #23679

Closed
felipeferreiraads opened this issue Apr 13, 2023 · 8 comments
Closed

Updating superset frontend on production #23679

felipeferreiraads opened this issue Apr 13, 2023 · 8 comments

Comments

@felipeferreiraads
Copy link

Hi guys,

I'm trying to update production build assets for superset, but It looks like it's not updating.
Steps I'm doing:

  • Updated the code with the dev-server command: working great, had the updates normally.
  • Built the assets for production with npm run build command: it updates the assets on superset/static/assets

But when I build the a docker image, or get the app up with docker compose non-dev file, I'm getting the original version of the frontend. What can I do to get the frontend updated whitout have to run the frontend separately?

@dastagirshaikh
Copy link

dastagirshaikh commented Apr 16, 2023

Hi Team,
I'm also facing the same issue.
I have tried creating custom plugins.
preset-io/superset-plugin-chart-liquid#9

@aksharahegde
Copy link

Hey.. I am also facing same issue.
I deleted the volume as well. But, result is same after bringing up non-dev server.

@aksharahegde
Copy link

Got the reason. It's pulling the frontend code from dockerhub image.

in docker-compose-non-dev.yml, check the line,
x-superset-image: &superset-image apache/superset:${TAG:-latest-dev}

So it's not building from updated source code in local.

@abenzakour
Copy link

Got the reason. It's pulling the frontend code from dockerhub image.

in docker-compose-non-dev.yml, check the line, x-superset-image: &superset-image apache/superset:${TAG:-latest-dev}

So it's not building from updated source code in local.

Perfect remark, have you found a solution to modify the frontend in production ?

Thanks

@aksharahegde
Copy link

aksharahegde commented Dec 12, 2023

Got the reason. It's pulling the frontend code from dockerhub image.
in docker-compose-non-dev.yml, check the line, x-superset-image: &superset-image apache/superset:${TAG:-latest-dev}
So it's not building from updated source code in local.

Perfect remark, have you found a solution to modify the frontend in production?

Thanks

Hey, Sorry.
Actually, I am able to build and deploy on our sandbox server. But later, plans changed and using superset is dropped, and now I forgot what I had done.

But I have added the docker-compose-non-dev-local.yml file to run on the Sandbox server.
Link to repo:
https://github.com/aksharahegde/superset-fork

@abenzakour
Copy link

Got the reason. It's pulling the frontend code from dockerhub image.
in docker-compose-non-dev.yml, check the line, x-superset-image: &superset-image apache/superset:${TAG:-latest-dev}
So it's not building from updated source code in local.

Perfect remark, have you found a solution to modify the frontend in production?
Thanks

Hey, Sorry. Actually, I am able to build and deploy on our sandbox server. But later, plans changed and using superset is dropped, and now I forgot what I had done.

But I have added the docker-compose-non-dev-local.yml file to run on the Sandbox server. Link to repo: https://github.com/aksharahegde/superset-fork

But even here on your local yml; you didn’t change source repository, it comes from apache/superset :
image

@epuga-aseg
Copy link

I had to do something similar to what OP was struggling with. I added some custom geojsons for the country map chart.

I compiled my own docker image with the changes using the following command:

docker build -t my-custom-superset .

And then inside my docker-compose-non-dev.yml file changed:

x-superset-image: &superset-image apachesuperset.docker.scarf.sh/apache/superset:${TAG:-latest}

to

x-superset-image: &superset-image my-custom-superset:latest

@rusackas
Copy link
Member

Seems like this thread has gone silent, and I assume all is well.

If others in the future run into such things, please feel free to open a Q&A Discussion, join the #deploying-superset channel on slack.

Also, if anyone on this thread feels that any of the above should be part of Superset's documentation, I strongly encourage you to make an easy PR and update the markdown files with relevant info.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants