Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(dashboard): Improve performance of the native filters config modal #21147

Closed
kgabryje opened this issue Aug 22, 2022 · 2 comments
Closed
Assignees
Labels
dashboard:performance Related to Dashboard performance

Comments

@kgabryje
Copy link
Member

When user has a big dashboard and many native filters added, the filters config modal is very laggy and unresponsive.
We should:

  1. Improve the structure of components that build filters config modal (for example FiltersConfigForm has over 1200 lines...)
  2. Reduce the number of unnecessary rerenders (with React.memo, useCallback, useMemo). To measure and find unnecessary rerenders I recommend library whyDidYouRender
  3. Measure the performance of filters config modal with Chrome devtools and try to optimize anything that stands out.
@rusackas
Copy link
Member

@kgabryje should we consider this closed after the aforementioned merged PRs?

@kgabryje
Copy link
Member Author

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:performance Related to Dashboard performance
Projects
None yet
Development

No branches or pull requests

3 participants