Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection and host liveness checks use only ipv4 #21041

Closed
vin01 opened this issue Aug 10, 2022 · 1 comment
Closed

Connection and host liveness checks use only ipv4 #21041

vin01 opened this issue Aug 10, 2022 · 1 comment
Labels
#bug Bug report

Comments

@vin01
Copy link
Contributor

vin01 commented Aug 10, 2022

Hi,

currently hostname validation (https://github.com/apache/superset/blob/master/superset/utils/network.py#L42) and port check (https://github.com/apache/superset/blob/master/superset/utils/network.py#L25) use only ipv4 addresses (because of gethostbyname and AF_INET respectively)

This results in ipv6 only hostnames being marked as invalid and ports show up as closed.

Both of these can be. fixed by using getaddrinfo.

I am creating this single issue to track both these bugs as they are related. Hopefully that is alright with the guidelines ;)

Please review related patches.

Thanks!

@betodealmeida
Copy link
Member

Thanks for the PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants