We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
currently hostname validation (https://github.com/apache/superset/blob/master/superset/utils/network.py#L42) and port check (https://github.com/apache/superset/blob/master/superset/utils/network.py#L25) use only ipv4 addresses (because of gethostbyname and AF_INET respectively)
gethostbyname
AF_INET
This results in ipv6 only hostnames being marked as invalid and ports show up as closed.
Both of these can be. fixed by using getaddrinfo.
getaddrinfo
I am creating this single issue to track both these bugs as they are related. Hopefully that is alright with the guidelines ;)
Please review related patches.
Thanks!
The text was updated successfully, but these errors were encountered:
Thanks for the PRs!
Sorry, something went wrong.
No branches or pull requests
Hi,
currently hostname validation (https://github.com/apache/superset/blob/master/superset/utils/network.py#L42) and port check (https://github.com/apache/superset/blob/master/superset/utils/network.py#L25) use only ipv4 addresses (because of
gethostbyname
andAF_INET
respectively)This results in ipv6 only hostnames being marked as invalid and ports show up as closed.
Both of these can be. fixed by using
getaddrinfo
.I am creating this single issue to track both these bugs as they are related. Hopefully that is alright with the guidelines ;)
Please review related patches.
Thanks!
The text was updated successfully, but these errors were encountered: