Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify all the visualizations! #1994

Closed
mistercrunch opened this issue Jan 17, 2017 · 0 comments · Fixed by #2005
Closed

Simplify all the visualizations! #1994

mistercrunch opened this issue Jan 17, 2017 · 0 comments · Fixed by #2005
Assignees

Comments

@mistercrunch
Copy link
Member

On the javascript side, a visualization definition should be as simple as defining a render function that receives the slice object and the data. Currently it's a js object that exposes a render and a resize method, and render is expected to fetch the data on its own.

In this proposed change, the data fetching should be handled by the "controller", not by the visualization itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant