Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Filter can't work when face NULL value or empty string #19264

Closed
2 of 3 tasks
zhaoyongjie opened this issue Mar 20, 2022 · 3 comments · Fixed by #19341
Closed
2 of 3 tasks

Native Filter can't work when face NULL value or empty string #19264

zhaoyongjie opened this issue Mar 20, 2022 · 3 comments · Fixed by #19341
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard dashboard Namespace | Anything related to the Dashboard explore:filter Related to filters in Explore validation:validated A committer has validated / submitted the issue or it was reported by multiple users

Comments

@zhaoyongjie
Copy link
Member

zhaoyongjie commented Mar 20, 2022

Native Filter can't work when facing NULL value or an empty string, and this behavior is not consistent with explore page.

native.filter.mov

How to reproduce the bug

  1. make a temporary table with a single text column by database client or SQLLab
create table testing_empty_string(
  name varchar(255)
);
insert into testing_empty_string
values
  (null),
  (''),
  ('foo');
  1. create a dataset from above table
  2. create a chart and dashboard from above dataset
  3. create a Native Filter from the dashboard
  4. got error when select <NULL> on dashboard
  5. got an empty placeholder when select <empty string> on dashboard
  6. got an error when select <NULL> on explore

Expected results

  1. Native filter should work with NULL
  2. Native filter should show when got a empty string
  3. filter should work with NULL on explore page

Actual results

Native filter can't work when facing NULL or Empty string

Environment

  • browser type and version: latest Firefox
  • superset version: current master branch(d645579)

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@zhaoyongjie zhaoyongjie added #bug Bug report dashboard:native-filters Related to the native filters of the Dashboard explore:filter Related to filters in Explore labels Mar 20, 2022
@villebro
Copy link
Member

Repro'd, thanks for reporting!

@villebro villebro added the dashboard Namespace | Anything related to the Dashboard label Mar 21, 2022
@srinify srinify added the validation:validated A committer has validated / submitted the issue or it was reported by multiple users label Mar 21, 2022
@michael-s-molina
Copy link
Member

Fixed by #19326

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Mar 23, 2022

Hi @michael-s-molina, The issue is still, so I reopen it. The explore page can't filter the null value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard dashboard Namespace | Anything related to the Dashboard explore:filter Related to filters in Explore validation:validated A committer has validated / submitted the issue or it was reported by multiple users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants