Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Total' contribution mode for time series chart doesnt work #18774

Closed
3 tasks done
alexamy opened this issue Feb 17, 2022 · 9 comments · Fixed by #18782
Closed
3 tasks done

'Total' contribution mode for time series chart doesnt work #18774

alexamy opened this issue Feb 17, 2022 · 9 comments · Fixed by #18782
Assignees
Labels
#bug Bug report validation:validated A committer has validated / submitted the issue or it was reported by multiple users

Comments

@alexamy
Copy link

alexamy commented Feb 17, 2022

When using 'Total' from 'contribution mode' there is no data.

How to reproduce the bug

  1. Create new time series chart
  2. Add metrics / group by clause
  3. Set 'contribution mode' to 'total'
  4. See no data

Expected results

Expect to see accumulated data chart.

Actual results

No data presented on the chart.

Screenshots

image

Relates to #11792, I've tried to repeat steps in this video, and got different results. My attempt.

Environment

  • browser version: Google Chrome 98.0.4758.102

I'm using superset in container from this docker image:
docker pull apache/superset:993278d8ad2d9be90c5484e3cfe61936c22b850d

These commands were runned in the container:

  • superset version: Superset 0.0.0dev
  • python version: Python 3.8.12
  • node.js version: (no executable found in $PATH in container)
  • any feature flags active: PREVENT_UNSAFE_DB_CONNECTIONS = False

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@alexamy alexamy added the #bug Bug report label Feb 17, 2022
@alexamy alexamy changed the title 'Total' contribution mode for time series chart doesnt working 'Total' contribution mode for time series chart doesnt work Feb 17, 2022
@zhaoyongjie zhaoyongjie added the validation:validated A committer has validated / submitted the issue or it was reported by multiple users label Feb 17, 2022
@zhaoyongjie zhaoyongjie self-assigned this Feb 17, 2022
@alexamy
Copy link
Author

alexamy commented Feb 18, 2022

@zhaoyongjie Have you tried to repeat case with birth_names chart, as in video?
I'm using last version from master and run it with docker compose, but have empty results again.
Btw, thanks a lot for quick response and fix!

@zhaoyongjie
Copy link
Member

Hey @alexamy, It works in my local environment(latest master branch). BTW, do you get Contribution mode selection change?

image

image

@alexamy
Copy link
Author

alexamy commented Feb 18, 2022

Thanks, I needed to pull newest docker images before start. Now it's working as on your screenshot!

@jaimefr
Copy link

jaimefr commented Mar 16, 2022

@alexamy @zhaoyongjie this is a bug from version 1.4.1 that will be resolved in the next release? I am facing the same issue and I don't even have the Contribution mode = Row option

@alexamy
Copy link
Author

alexamy commented Mar 16, 2022

@jaimefr Hi! I'm using docker compose for local installation, installation guide: https://superset.apache.org/docs/installation/installing-superset-using-docker-compose/.
You need to pull latest docker images with command docker-compose -f docker-compose-non-dev.yml pull, if there is a new release, not just pulling the repository master branch.

I saw updated version of contibution mode after perfoming these steps.

@jaimefr
Copy link

jaimefr commented Mar 30, 2022

@alexamy @zhaoyongjie I have upgraded to Superset 1.4.2 and this still doesn't work. Do you have if the fix has been excluded of the release?

@zhaoyongjie
Copy link
Member

@alexamy @zhaoyongjie I have upgraded to Superset 1.4.2 and this still doesn't work. Do you have if the fix has been excluded of the release?

Do you try the master branch? I think this issue has been fixed in the latest master but not been released yet.

@villebro
Copy link
Member

@jaimefr @alexamy: @zhaoyongjie is right - the 1.4 branch is unfortunately so old that these recent PRs weren't possible to cherry into 1.4.2. Having said that 1.5.0 is currently in the works, and the first release candidate should be made available this week.

@jaimefr
Copy link

jaimefr commented Mar 30, 2022

@villebro thanks, so we can expect this to be solved in 1.5
@zhaoyongjie no, we haven't tried, we only deploy official releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report validation:validated A committer has validated / submitted the issue or it was reported by multiple users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants