Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql lab] show run button even when no database is selected #1849

Closed
ascott opened this issue Dec 15, 2016 · 3 comments
Closed

[sql lab] show run button even when no database is selected #1849

ascott opened this issue Dec 15, 2016 · 3 comments
Assignees
Labels
sqllab Namespace | Anything related to the SQL Lab

Comments

@ascott
Copy link
Contributor

ascott commented Dec 15, 2016

  • if no database is selected, show run button as disabled
  • maybe choose a database by default on page load

no-run-btns

@ascott ascott added the sqllab Namespace | Anything related to the SQL Lab label Dec 15, 2016
@jefffeng
Copy link

jefffeng commented Dec 16, 2016

Rather than show the run button as disabled when no database is selected, could we show the run button as disabled only when no database is selected AND no text has been altered in the query window? I want to ensure we support the use case where a user copies and pastes a query into a new tab.

@ascott
Copy link
Contributor Author

ascott commented Dec 16, 2016

i believe it is a requirement to choose a database before running your query even if you have just pasted a query into the sql editor pane. the sql query should determine the schema and table but does not specify the database afaik, which is why it needs to be choosen from the dropdown.

another option here is to always choose a default db so if the user pastes a query into the editor they will be able to run the query right away. if it's against the wrong db, they should get a useful error message.

@ascott ascott self-assigned this Feb 2, 2017
@ascott
Copy link
Contributor Author

ascott commented Feb 3, 2017

looks like this was fixed already.

screenshot 2017-02-02 18 27 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sqllab Namespace | Anything related to the SQL Lab
Projects
None yet
Development

No branches or pull requests

2 participants