Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] metadata is missing schema in example datasets #16793

Closed
michael-s-molina opened this issue Sep 22, 2021 · 9 comments
Closed

[Examples] metadata is missing schema in example datasets #16793

michael-s-molina opened this issue Sep 22, 2021 · 9 comments
Labels
#bug Bug report good first issue Good first issues for new contributors inactive Inactive for >= 30 days need:followup Requires followup

Comments

@michael-s-molina
Copy link
Member

michael-s-molina commented Sep 22, 2021

Screen Shot 2021-10-12 at 7 35 22 AM

@michael-s-molina michael-s-molina added the #bug Bug report label Sep 22, 2021
@junlincc junlincc added good first issue Good first issues for new contributors P9 Priority item - Minor labels Sep 22, 2021
@junlincc junlincc changed the title Examples data is missing some metadata information [Examples] metadata is missing in example charts Sep 22, 2021
@michael-s-molina michael-s-molina changed the title [Examples] metadata is missing in example charts [Examples] metadata is missing schema in example charts Sep 27, 2021
@michael-s-molina michael-s-molina changed the title [Examples] metadata is missing schema in example charts [Examples] metadata is missing schema in example datasets Sep 27, 2021
@castellanos-ricardo
Copy link

Hey! I would like to help with this. Can you explain more about what the red lines mean, are the red lines just indicating that the slot is empty? Also, the "Owners" and "Modified by" columns shouldn't be empty?

@michael-s-molina
Copy link
Member Author

michael-s-molina commented Oct 12, 2021

@castellanos-ricardo Yes, the red lines are just indicating an empty slot. The "Owners" and "Modified by" columns can be empty. I updated the image. The tricky part here is that the name of the schema is database dependent, so it can be "public", "main", etc. @villebro Is there anything else that I'm missing?

@castellanos-ricardo
Copy link

@michael-s-molina Got it, I will work on this issue.

@junlincc
Copy link
Member

@castellanos-ricardo thank you for picking up this issue. @michael-s-molina thanks for the guidance. ❤️

@junlincc junlincc added need:followup Requires followup and removed P9 Priority item - Minor labels Oct 12, 2021
@ARES-79
Copy link

ARES-79 commented Oct 15, 2021

Hello! I am actually going to be working on this issue with @castellanos-ricardo, and I was wondering if it is known whether it is an issue of the schema not being created or just not reported in the datasets?

@michael-s-molina
Copy link
Member Author

I was wondering if it is known whether it is an issue of the schema not being created or just not reported in the datasets?

I think it's just an issue of not populating the schema in the examples metadata. If we edit one dataset and select a schema then the value is presented.

@marnze
Copy link

marnze commented Nov 7, 2021

Hi, I've been working on this with @castellanos-ricardo and @ARES-79. Looks like #16041 fixes this issue and this issue is a duplicate of #16051.

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

Closing in favor of #16051, and hopeful that #16041 fixed this (and maybe that one too!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report good first issue Good first issues for new contributors inactive Inactive for >= 30 days need:followup Requires followup
Projects
None yet
Development

No branches or pull requests

7 participants