-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Roles Page] page load is very slow #15854
Comments
The UI works. It is just slow. The DB is not slow as I am able to query the same tables ( |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
I have the same with the Superset 1.4.2 |
I have the same with the Superset 1.5.1. When go to List Roles Page, it calls Query:
|
Hey, folks! Have anyone found a workaround to this? I'm facing the same with version 2.0.1 and 2.1.0. |
Hi! |
There was similar issue in Airflow where roles and users page was slow apache/airflow#31340. The fix was to remove certain columns from filter with foreign key reference that causes queries to increase. In Airflow case created_by, changed_by were present in filter widget referencing to users and large number of users increased the the time it takes to load all users. Relevant flask-appbuilder issues |
If filtering by permission and users is not needed then please try adding superset/superset/security/manager.py Lines 137 to 139 in c53b249
|
@tirkarthi this solution is already in the Superset codebase and it doesn't work in the same way that people's solutions don't with modifying or cutting out the search. |
search_exclude_columns helps to fast load but permissions - absence bigger problem in representation: from this point we have big amount of queries to two tables ab_view_menu and ab_permission |
in log sqlalchemy looks good if u change model PermissionView to this:
|
if u have 50k+ virtual datasets - to edit very slow in frontend superset. u need to update security manager superset for check real tables and set sql updates (example):
|
also add to set_perm
|
I am facing this issue in version 3.1.0. The Role edit request taking more that minute. Any fix or work around available |
You can set this to FAB security model
|
Yup) File: flask_appbuilder/security/sqla/models.py
|
Thanks @Paulo456 and @happykust, It worked. |
@happykust @ambarishp I'm a little lost in all this now 😅 Is there something that needs to be done to close the loop here (adding documentation, a PR to fix things, etc.?) |
@rusackas I think the problem is that the superset is not designed for the number of dataset entities greater than 50 thousand. More precisely, the problem is not in the superset itself, but in the FAB model. The current solution is just a workaround. |
@rusackas The problem is solely in the Flask-AppBuilder library, in the file described above. Its author apparently does not want to fix this; there have already been a lot of discussions about this. In our company, we forked FAB, fixed it and are enjoying life. |
CC @dpgaspar |
@happykust I'm sorry to ear that, can you point to any current/past issue/PR on flask-appbuilder or open a new one please, so we can visit this. |
@dpgaspar I've been adding an issue for quite some time now. I switched it to closed status because of the solution found for me. Will you have a chance to fix this? Or are there any pitfalls when using the solution written above? |
@dpgaspar Thank you very much for the fixes! |
np, FAB 4.4.1 is released with the fix, bumping Superset also. |
Which version of Superset has this fix? The issue is still in 3.1.1.
|
Yep, Superset 3.1.1 doesn't have this fixes because of use FAB version 4.3.11, not 4.4.1. |
On superset 1.1.0 roles list page loading is slow. It takes approx. 16 seconds to load. From roles listing page if I click edit to edit a role then it takes 18 to 20seconds for the edit page to open up. This makes working with roles very difficult.
Viewing user list takes just 2s in comparison.
Expected results
Roles related pages to load in <5seconds.
Actual results
Roles related pages load in >15seconds.
Screenshots
See developer tools
How to reproduce the bug
Environment
(please complete the following information):
superset version
1.1.0python --version
Python 3.7.9node -v
NA. docker images does not have nodeChecklist
Make sure to follow these steps before submitting your issue - thank you!
The text was updated successfully, but these errors were encountered: