-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native filters] Select filter should allow user pick time column #14744
Comments
hi @graceguo-supercat i do remember you brought this up in the discussion. can you further explain what potential data quality issue means? 😅 |
Good catch - do I understand correctly, that the need is to add the Time Column control to the Select and Range filters? |
for example, i have 2 time columns in a dataset, |
yes. thank you!! |
@villebro @zhaoyongjie this is problematic, can we simply add a column select when there's 2 and more dataset is available, and make it dynamic? |
For quick fix that's ok.. eventually we need to remove the time range and blend it into a regular filter though. let's go for the easy solution for now! 😛 |
Current Select type filter component has
time range
control, but doesn't offer atime column
control. For a dataset has multiple time columns, this will introduce a potential data quality issue.Screenshots
This is screenshot to explain how filter_box is used in airbnb: A filter field, which is not a
Date filter
, it can still havetime range
andtime column
to limit the available choices. For example, with "Last 180 days" time range, this filter has 6 options, while without 180 days limit, it will show 8 options:Environment
latest master
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
I remember we discussed this issue in the next version of filter configure modal design. So i assume @junlincc is aware of this issue. I created an issue is to make sure backend can handle the extra query parameter for native filter component. cc @villebro
The text was updated successfully, but these errors were encountered: