[Dashboard] Error message for draft/deleted dashboards is not actionable

[ktmud]

Error message for draft/deleted dashboards is not actionable. Probably related: #13306

cc @pkdotson @suddjian @junlincc

Expected results

Deleted or unpublished dashboards should render a "Dashboard not found" or a general 404 page.

Actual results

It shows a blank page with unexpected JS errors or JSON format 404 error

Screenshots

When visiting a draft dashboard you don't have access with:

When visiting a non-existing dashboard:

How to reproduce the bug

1. Create a new dashboard
2. Log out and login as another user
3. Visit that dashboard

Environment

Latest master

[ktmud]

Previously unpublished (draft) dashboards are still viewable by others with Dashboard view access. With recent changes it now throws the NotFound errors.

Our users rely on not publishing a dashboard to prevent it from being discovered in searches, while allowing circulating it among a smaller group of users---kind of like YouTube's "Unlisted videos", or Google Docs' "allow anyone with this link to have access".

This change introduced a lot of frictions to our existing workflow so it would be good if we can revert back to the old behavior while waiting for a long-term fix.

[junlincc]

thanks for reporting, could you revert internally and give us a couple of days to address it? @ktmud

[ktmud]

Some may actually find that other users being able to access unpublished dashboards a bug not a feature, especially that the dashboard ids are not randomized, making it possible for users to see dashboards that they are not intended to see.

Long term solution is to introduce a "unlisted" ("viewable but not searchable") dashboard status, in addition to the "draft" and "published" status. This can go hand in hand with the Trashbin feature, too.

In the meantime, we should revert back to previous behavior---draft == unlisted---to avoid breaking existing user workflows.