Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore][Control] Allow selecting ad-hoc metrics in filters #13249

Closed
ktmud opened this issue Feb 20, 2021 · 9 comments
Closed

[Explore][Control] Allow selecting ad-hoc metrics in filters #13249

ktmud opened this issue Feb 20, 2021 · 9 comments
Labels
#bug:regression Bugs that are identified as regessions explore:filter Related to filters in Explore inactive Inactive for >= 30 days

Comments

@ktmud
Copy link
Member

ktmud commented Feb 20, 2021

When adhoc filters were first added ( #4909 ), it can select from selected adhoc metrics. Part of the code is also still there, but the feature somehow stopped working from certain point.

Could be related to #12095

@ktmud ktmud added #bug:regression Bugs that are identified as regessions #bug Bug report labels Feb 20, 2021
@ktmud
Copy link
Member Author

ktmud commented Feb 20, 2021

I discovered this while working on #13221

Will take a look once more refactoring is done.

@junlincc junlincc added explore:filter Related to filters in Explore and removed #bug Bug report labels Feb 20, 2021
@junlincc
Copy link
Member

Will take a look once more refactoring is done.

happy to take it on while we are refractor the filter component in a few weeks. @ktmud
@zuzana-vej can you provide a complete list of expected behavior in ad hoc filter and metric popover, + new features suggestion (i.e, in-place saving metric)?

@ktmud
Copy link
Member Author

ktmud commented Feb 21, 2021

Two feature requests I've been thinking on for a while:

  1. Adhoc Column: similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)
  2. Adhoc metric/column in other controls: users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).

@villebro
Copy link
Member

Two feature requests I've been thinking on for a while:

  1. Adhoc Column: similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)

  2. Adhoc metric/column in other controls: users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).

Big +1 for adhoc columns!

@junlincc
Copy link
Member

junlincc commented Feb 21, 2021

@villebro @ktmud hey both, please take a look the draft 1 year roadmap for Explore and send me comments, thoughts before I finalize? I believe we captured most of the significant items requested by the community.
shared a gsheet link with you, please comment directly on it. 🙏

Screen Shot 2021-02-21 at 10 23 33 AM

Screen Shot 2021-02-21 at 10 23 51 AM

@zhaoyongjie
Copy link
Member

zhaoyongjie commented Feb 22, 2021

Two feature requests I've been thinking on for a while:

1. **Adhoc Column:** similar to adhoc metrics, users should also be able to create adhoc calculated columns (dimensions)

2. **Adhoc metric/column in other controls:** users should be able to select already created adhoc metrics and columns in other controls (e.g. sort by and filters).

I'm trying to redesign the semantic layer, it might help. these are good requests.

@junlincc
Copy link
Member

Thank you all for suggesting new features.
committed to both.

@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 2, 2022
@rusackas
Copy link
Member

Since this has gone stale, and adhoc columns are effectively "a thing" nowdays, I'll close this out, but if there's more to track down, maybe we can open a fresh thread with updated context.

@rusackas rusackas closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions explore:filter Related to filters in Explore inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

5 participants