Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table viz, sorting by column "version" is broken in Chrome #1307

Closed
0x0ece opened this issue Oct 10, 2016 · 3 comments
Closed

Table viz, sorting by column "version" is broken in Chrome #1307

0x0ece opened this issue Oct 10, 2016 · 3 comments

Comments

@0x0ece
Copy link
Contributor

0x0ece commented Oct 10, 2016

I'm reporting a bug which is really about DataTables more than Caravel, but it may affect Caravel users.

We have table visualizations with a version field (e.g. our app version), and sorting by that column breaks in Chrome.

The issue is that DataTables attempts to auto detect dates, which is not working properly on Chrome. Here's the issue:
https://github.com/DataTables/DataTables/issues/874

Let's monitor for a new version of DataTables that hopefully will fix this. I'll keep an eye on it.

@0x0ece
Copy link
Contributor Author

0x0ece commented Oct 10, 2016

Temporary fix is to edit caravel/assets/node_modules/datatables.net/js/jquery.dataTables.js and comment out lines 14769-14771:

        //"date-pre": function ( d ) {
        //  return Date.parse( d ) || 0;
        //},

Then re-run npm run prod (or npm run dev).

@mistercrunch
Copy link
Member

Oh interesting. Thanks for documenting / sharing. You can keep track of our npm dependencies and wether they are updated here:
https://david-dm.org/airbnb/caravel?path=caravel/assets

@0x0ece
Copy link
Contributor Author

0x0ece commented Jan 21, 2017

It's been fixed, closing.

@0x0ece 0x0ece closed this as completed Jan 21, 2017
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 17, 2021
* feat: bignumber format by time formatter

* fix ut

* rename control label
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 24, 2021
* feat: bignumber format by time formatter

* fix ut

* rename control label
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 25, 2021
* feat: bignumber format by time formatter

* fix ut

* rename control label
zhaoyongjie added a commit to zhaoyongjie/incubator-superset that referenced this issue Nov 26, 2021
* feat: bignumber format by time formatter

* fix ut

* rename control label
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants