Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql_lab]Ctrl + t shortcut in SQL Lab opens new tab in Chrome/PC #12429

Closed
3 tasks done
eschutho opened this issue Jan 12, 2021 · 7 comments
Closed
3 tasks done

[sql_lab]Ctrl + t shortcut in SQL Lab opens new tab in Chrome/PC #12429

eschutho opened this issue Jan 12, 2021 · 7 comments
Labels
assigned:preset Assigned to the Preset team inactive Inactive for >= 30 days sqllab:editor

Comments

@eschutho
Copy link
Member

eschutho commented Jan 12, 2021

The tooltip for the new tab instructs users to use Ctrl + t for a new tab, but this doesn't work on a PC. On a PC Ctrl + t opens a new browser tab.
_DEV__Superset

Suggested solution: change the tooltip to suggest using Ctrl +q for PC users and update the keyboard shortcuts.

Expected results

The instructions in the tooltip should open a new SQL Lab tab.

Actual results

Following the instructions on a PC opens a new Chrome tab.

How to reproduce the bug

  1. Go to /superset/sqllab
  2. Hover over the "+" icon next to the tabs for the instructions
  3. Hit Ctrl + t in Chrome on a PC
  4. A new Chrome tab opens

Environment

  • superset version: 1.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar. (Closed that issue for this one which is more accurate given the recent changes)
@eschutho
Copy link
Member Author

I'm going to claim this ticket for someone on my team.

@junlincc junlincc changed the title Ctrl + t shortcut in SQL Lab opens new tab in Chrome/PC [sql_lab]Ctrl + t shortcut in SQL Lab opens new tab in Chrome/PC Jan 12, 2021
@junlincc junlincc added assigned:preset Assigned to the Preset team sqllab:editor and removed #bug Bug report preset-io labels Jan 12, 2021
@hughhhh hughhhh assigned hughhhh and unassigned hughhhh Jan 25, 2021
@hughhhh
Copy link
Member

hughhhh commented Jan 25, 2021

@lyndsiWilliams is working on this now

@rumbin
Copy link
Contributor

rumbin commented Mar 26, 2021

Not sure if this is caused by the same effects, but Ctrl+X for cutting is also not working on a PC in Chrome or Firefox.
Should I open a new ticket for this or is it closely related?

@eschutho
Copy link
Member Author

@yousoph ?

@yousoph
Copy link
Member

yousoph commented Apr 5, 2021

Hi @rumbin , a new issue would be good for the ctrl+x shortcut. This particular one should be resolved already with this change: #12772

Thanks!

@stale
Copy link

stale bot commented May 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label May 2, 2022
@rusackas
Copy link
Member

The acute issue in the original report was closed by #12772

If there are related key command bugs, let's open those under separate cover, and add any feature requests as Discussions. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned:preset Assigned to the Preset team inactive Inactive for >= 30 days sqllab:editor
Projects
None yet
Development

No branches or pull requests

6 participants