Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Can not remove row inside Tab #11681

Closed
3 tasks done
graceguo-supercat opened this issue Nov 12, 2020 · 3 comments
Closed
3 tasks done

[dashboard] Can not remove row inside Tab #11681

graceguo-supercat opened this issue Nov 12, 2020 · 3 comments
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@graceguo-supercat
Copy link

In dashboard, user can not remove a Row component inside a Tab component. But if Row is added without Tab, it could be removed.

Screenshots

MQc0JjOP2y

Environment

latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Cause by #11160. CC @kgabryje @junlincc @zuzana-vej this is a high priority issue.

@graceguo-supercat graceguo-supercat added the !deprecated-label:bug Deprecated label - Use #bug instead label Nov 12, 2020
@junlincc
Copy link
Member

junlincc commented Nov 13, 2020

got it, thanks for linking the PR! @graceguo-supercat 🙏

@junlincc
Copy link
Member

#11691 @graceguo-supercat ready for you review, 8 hours from reporting, not too bad right? 😉

@junlincc
Copy link
Member

Screen Shot 2020-11-16 at 8 06 40 AM

tested all good. closing

fix by #11691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

2 participants