4.1.0rc1

[eschutho]

Hello Superset Community,

This is a call for the vote to release Apache Superset version 4.1.0.

The release candidate:
https://dist.apache.org/repos/dist/dev/superset/4.1.0rc1/

The Git tag for the release:
https://github.com/apache/superset/tree/4.1.0rc1

The CHANGELOG for the release:
https://github.com/apache/superset/blob/4.1.0rc1/CHANGELOG/4.1.0.md

The instructions for updating to the release:
https://github.com/apache/superset/blob/4.1.0rc1/UPDATING.md

Public keys are available at:
https://www.apache.org/dist/superset/KEYS

---

This discussion was created from the release 4.1.0rc1.

[padbk]

I have this bug #29708 which is not present in 4.0.2.

[sfirke]

@sadpandajoe I looked through old PRs and I couldn't find one where this changed either 🤷 thanks for looking. I guess if someone figures it out in time we can revert, otherwise I'll just point people to that issue where the fix has been posted

[wdav]

It appears that this PR #28158 and commit 2d63722 removed the imports of scheduler and cache from superset/tasks/celery_app.py:L34-35 which causes no task named reports.scheduler, etc, to be found if they were not explicitly defined in the config imports.

[2d63722] superset/tasks/celery_app.py:L34-35

# Need to import late, as the celery_app will have been setup by "create_app()"
- # pylint: disable=wrong-import-position, unused-import
- from . import cache, scheduler  # isort:skip

This can be fixed, as found above, by updating the config to explicitly import it.

But, as there is no context to the removal of this line in the PR, I'm guessing it was not intended?

[sadpandajoe]

@mistercrunch I'm guessing this was probably just removed by accident by ruff as they were unused imports. I'll create a PR to address this.

[sadpandajoe]

Great find @wdav, I've created the PR: #29921 to address this.

[mistercrunch]

Oh yes that has to be it. Sorry about that.

[Habeeb556]

Hopefully, this bug #28145 can be merged.

[Habeeb556]

Sorry, I was using Python 3.8, not 3.9, which is not supported for the upgrade. So, I upgraded to the latest version 3.11.

[Habeeb556]

@sadpandajoe, I tried using now a virtual venv with Python 3.10.2 and encountered the same error when checking "Query History":

An error occurred while fetching Query history: 'Template' object has no attribute 'strip'

[ivan-basiuk]

Hi, will this be fixed in 4.1.0?

[sadpandajoe]

Doesn't look like the PR owner has made any updates to their PR. If it gets merged we can try to cherry it in, but I don't see this as a blocker as it's already happening as part of 4.0.2 for some users.

[Habeeb556]

++ @toniphan21 #28357

[iercan]

Please see below bugs.

#29727
#29728
#29729

[eschutho]

thank you @iercan!

[sadpandajoe]

#29728 - fixed with #29780

[sadpandajoe]

Looks like we weren't able to reproduce the issue in #29729 so I wouldn't say this is a blocker for 4.1 until we can find something that is reproducible.

[michael-s-molina]

#29789

[sadpandajoe]

thanks @michael-s-molina. I'll make sure I cherry this into the next RC

[sadpandajoe]

fixed with #29799

[michael-s-molina]

#29801

[michael-s-molina]

I provided a fix here.

[sadpandajoe]

I think once the PR is merged, we can create RC2 and put it up for another vote.

[iercan]

#27416 also still persist with different error. I added comment on issue.

[sadpandajoe]

I don't think this is a blocker for 4.1 since it's happening in 3.1.1 and 4.0

[Habeeb556]

@eschutho could you push this pre-release 4.1.0rc1 to PyPI for testing?

[eschutho]

Since 4.1.0rc1 was downvoted, we'll push one up for rc2.

[sadpandajoe]

I'll work on creating a rc2 once #29860 is merged and put it up for another round of voting

[Habeeb556]

@sadpandajoe please push this pre-release 4.1.0rc2 to PyPI for testing.

[benvdh-incentro]

@Habeeb556 It has been released 16 hours ago: https://github.com/apache/superset/releases/tag/4.1.0rc2

The discussion can be found here: #29999

[Habeeb556]

Yes I know, but I need it on PyPI, so I can pip install it.

[michael-s-molina]

#29884

[sadpandajoe]

thanks @michael-s-molina for fixing this

[michael-s-molina]

#29906

[sadpandajoe]

will cherry in rc2

[exolightor]

In 4.1.0rc1 we are running into this issue which is not present on 4.1.0 nor on master: #29931

[sadpandajoe]

@exolightor mind looking again when we cut rc2? 4.1.0rc1 didn't pass and it looks like we are waiting on a couple more fixes before we can cut RC2.