From c5f2eafc906bebf1d238e62ff5a8821cf549220c Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Wed, 31 May 2017 14:31:13 -0700 Subject: [PATCH] [explore] 'Save as' -> 'Save' as it can be used to overwrite (#2875) * [explore] 'Save as' -> 'Save' as it can be used to overwrite * Fix tests --- .../assets/javascripts/explore/components/QueryAndSaveBtns.jsx | 2 +- .../javascripts/explore/components/QueryAndSaveBtns_spec.jsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx b/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx index b9ce21f80bce6..8fe95fcba65ab 100644 --- a/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx +++ b/superset/assets/javascripts/explore/components/QueryAndSaveBtns.jsx @@ -56,7 +56,7 @@ export default function QueryAndSaveBtns( disabled={saveButtonDisabled} onClick={onSave} > - Save as + Save {errorMessage && diff --git a/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx b/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx index 78e5552ebe397..4f7d4e1b05555 100644 --- a/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx +++ b/superset/assets/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx @@ -32,7 +32,7 @@ describe('QueryAndSaveButtons', () => { it('renders buttons with correct text', () => { expect(wrapper.find(Button).contains(' Query')).to.eql(true); - expect(wrapper.find(Button).contains(' Save as')).to.eql(true); + expect(wrapper.find(Button).contains(' Save')).to.eql(true); }); it('calls onQuery when query button is clicked', () => {