Skip to content

Commit

Permalink
add extra comments to avoid happening again
Browse files Browse the repository at this point in the history
  • Loading branch information
Grace committed Feb 3, 2021
1 parent 6bc9931 commit c2fefb6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions superset/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,11 @@ class CeleryConfig: # pylint: disable=too-few-public-methods
# It will get executed each time when user open a chart's explore view.
DATASET_HEALTH_CHECK = None

# -------------------------------------------------------------------
# * WARNING: STOP EDITING HERE *
# -------------------------------------------------------------------
# Don't add config values below this line since local configs won't be
# able to override them.
if CONFIG_PATH_ENV_VAR in os.environ:
# Explicitly import config module that is not necessarily in pythonpath; useful
# for case where app is being executed via pex.
Expand Down
2 changes: 2 additions & 0 deletions superset/connectors/sqla/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,8 @@ def data(self) -> Dict[str, Any]:
data_["fetch_values_predicate"] = self.fetch_values_predicate
data_["template_params"] = self.template_params
data_["is_sqllab_view"] = self.is_sqllab_view
# Don't return previously populated health check message in case
# the health check feature is turned off
data_["health_check_message"] = (
self.health_check_message
if config.get("DATASET_HEALTH_CHECK")
Expand Down

0 comments on commit c2fefb6

Please sign in to comment.