From 848c565c8c3f2b0d17251891ccd94dbb7663b32c Mon Sep 17 00:00:00 2001
From: John Bodley <4567245+john-bodley@users.noreply.github.com>
Date: Mon, 3 Feb 2020 10:37:29 -0800
Subject: [PATCH] [sip-15] Enabling SIP-15 by default (#9017)

---
 UPDATING.md         | 7 +++++++
 superset/config.py  | 2 +-
 tests/core_tests.py | 2 ++
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/UPDATING.md b/UPDATING.md
index 2e9c85a4913e3..0076259034cd4 100644
--- a/UPDATING.md
+++ b/UPDATING.md
@@ -46,6 +46,13 @@ now uses UTC for the tooltips and default placeholder timestamps (sans timezone)
 have changed. FLASK_APP should be updated to `superset.app:create_app()` and Celery Workers
 should be started with `--app=superset.tasks.celery_app:app`
 
+* [9017](https://github.com/apache/incubator-superset/pull/9017): `SIP_15_ENABLED` now
+defaults to True which ensures that for all new SQL charts the time filter will behave
+like [start, end). Existing deployments should either disable this feature to keep the
+status quo or inform their users of this change prior to enabling the flag. The
+`SIP_15_GRACE_PERIOD_END` option provides a mechanism for specifying how long chart
+owners have to migrate their charts (the default is indefinite).
+
 ## 0.35.0
 
 * [8370](https://github.com/apache/incubator-superset/pull/8370): Deprecates
diff --git a/superset/config.py b/superset/config.py
index 7bd9b92604238..006a7ac78c4fc 100644
--- a/superset/config.py
+++ b/superset/config.py
@@ -749,7 +749,7 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 #
 # Note if no end date for the grace period is specified then the grace period is
 # indefinite.
-SIP_15_ENABLED = False
+SIP_15_ENABLED = True
 SIP_15_GRACE_PERIOD_END: Optional[date] = None  # exclusive
 SIP_15_DEFAULT_TIME_RANGE_ENDPOINTS = ["unknown", "inclusive"]
 SIP_15_TOAST_MESSAGE = (
diff --git a/tests/core_tests.py b/tests/core_tests.py
index 4de0171b51109..4ef60de590043 100644
--- a/tests/core_tests.py
+++ b/tests/core_tests.py
@@ -244,6 +244,7 @@ def test_save_slice(self):
             "metric": "sum__value",
             "row_limit": 5000,
             "slice_id": slice_id,
+            "time_range_endpoints": ["inclusive", "exclusive"],
         }
         # Changing name and save as a new slice
         resp = self.client.post(
@@ -265,6 +266,7 @@ def test_save_slice(self):
             "row_limit": 5000,
             "slice_id": new_slice_id,
             "time_range": "now",
+            "time_range_endpoints": ["inclusive", "exclusive"],
         }
         # Setting the name back to its original name by overwriting new slice
         self.client.post(