Skip to content

Commit

Permalink
Unnecessary to specify order_columns for DatasourceModelView (#3331)
Browse files Browse the repository at this point in the history
  • Loading branch information
roganw authored and mistercrunch committed Aug 18, 2017
1 parent 0454ef3 commit 813ed60
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions superset/connectors/druid/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ class DruidDatasourceModelView(DatasourceModelView, DeleteMixin): # noqa
list_widget = ListWidgetWithCheckboxes
list_columns = [
'datasource_link', 'cluster', 'changed_by_', 'modified']
order_columns = [
'datasource_link', 'changed_on_', 'offset']
related_views = [DruidColumnInlineView, DruidMetricInlineView]
edit_columns = [
'datasource_name', 'cluster', 'slices', 'description', 'owner',
Expand Down
2 changes: 0 additions & 2 deletions superset/connectors/sqla/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,6 @@ class TableModelView(DatasourceModelView, DeleteMixin): # noqa
list_columns = [
'link', 'database',
'changed_by_', 'modified']
order_columns = [
'link', 'database', 'changed_on_']
add_columns = ['database', 'schema', 'table_name']
edit_columns = [
'table_name', 'sql', 'filter_select_enabled', 'slices',
Expand Down

0 comments on commit 813ed60

Please sign in to comment.