diff --git a/superset/assets/javascripts/explore/components/ControlHeader.jsx b/superset/assets/javascripts/explore/components/ControlHeader.jsx index 842df1e59f5b7..dd611f9dd968f 100644 --- a/superset/assets/javascripts/explore/components/ControlHeader.jsx +++ b/superset/assets/javascripts/explore/components/ControlHeader.jsx @@ -5,7 +5,7 @@ import InfoTooltipWithTrigger from '../../components/InfoTooltipWithTrigger'; import { t } from '../../locales'; const propTypes = { - label: PropTypes.string.isRequired, + label: PropTypes.string, description: PropTypes.string, validationErrors: PropTypes.array, renderTrigger: PropTypes.bool, @@ -52,6 +52,9 @@ export default class ControlHeader extends React.Component { return null; } render() { + if (!this.props.label) { + return null; + } const labelClass = (this.props.validationErrors.length > 0) ? 'text-danger' : ''; return (
{this.props.placeholder}
; } - const control = controlMap[this.props.control]; + const Control = controlMap[this.props.controlName]; return (
- diff --git a/superset/assets/javascripts/explore/stores/controls.jsx b/superset/assets/javascripts/explore/stores/controls.jsx index ff6c833018c43..8d470f0aaa3c9 100644 --- a/superset/assets/javascripts/explore/stores/controls.jsx +++ b/superset/assets/javascripts/explore/stores/controls.jsx @@ -1443,7 +1443,7 @@ export const controls = { type: 'CollectionControl', label: t('Time Series Columns'), validators: [v.nonEmpty], - control: 'TimeSeriesColumnControl', + controlName: 'TimeSeriesColumnControl', }, }; diff --git a/superset/assets/package.json b/superset/assets/package.json index d87474b9ae9cf..d2148a96e0db5 100644 --- a/superset/assets/package.json +++ b/superset/assets/package.json @@ -85,7 +85,7 @@ "react-syntax-highlighter": "^5.7.0", "react-virtualized": "^9.3.0", "react-virtualized-select": "^2.4.0", - "reactable": "^0.14.0", + "reactable": "^0.14.1", "redux": "^3.5.2", "redux-localstorage": "^0.4.1", "redux-thunk": "^2.1.0", diff --git a/superset/assets/visualizations/time_table.jsx b/superset/assets/visualizations/time_table.jsx index a570874b19189..89e9676a7313f 100644 --- a/superset/assets/visualizations/time_table.jsx +++ b/superset/assets/visualizations/time_table.jsx @@ -23,8 +23,8 @@ function FormattedNumber({ num, format }) { return {num}; } FormattedNumber.propTypes = { - num: propTypes.number.isRequired, - format: propTypes.string.isRequired, + num: propTypes.number, + format: propTypes.string, }; function viz(slice, payload) {