Merge pull request #161 from mistercrunch/chris/eslint

Add linting to package.json, do all of the linting.
apache · Mar 4, 2016 · 1782d8f · 1782d8f
2 parents a7e75a2 + 68f8937
commit 1782d8f
Show file tree

Hide file tree

Showing 24 changed files with 621 additions and 435 deletions.
diff --git a/panoramix/assets/.eslintignore b/panoramix/assets/.eslintignore
@@ -0,0 +1,3 @@
+node_modules/*
+vendor/*
+javascripts/dist/*
diff --git a/panoramix/assets/.eslintrc b/panoramix/assets/.eslintrc
@@ -0,0 +1,234 @@
+{
+  "root": true,
+
+  "globals": {
+    "Symbol": false,
+    "Map": false,
+    "Set": false,
+    "Reflect": false,
+  },
+
+  "env": {
+    "es6": false,
+    "browser": true,
+    "node": true,
+  },
+
+  "parserOptions": {
+    "ecmaVersion": 5,
+    "sourceType": "module"
+  },
+
+  "rules": {
+    "array-bracket-spacing": [2, "never", {
+      "singleValue": false,
+      "objectsInArrays": false,
+      "arraysInArrays": false
+    }],
+    "array-callback-return": [2],
+    "block-spacing": [2, "always"],
+    "brace-style": [2, "1tbs", { "allowSingleLine": true }],
+    "callback-return": [2, ["callback"]],
+    "camelcase": [0],
+    "comma-dangle": [2, "never"],
+    "comma-spacing": [2],
+    "comma-style": [2, "last"],
+    "curly": [2, "all"],
+    "eqeqeq": 2,
+    "func-names": [0],
+    "id-length": [2, { "min": 1, "max": 25, "properties": "never" }],
+    "key-spacing": [2, { "beforeColon": false, "afterColon": true }],
+    "keyword-spacing": [2, {
+      "before": true,
+      "after": true,
+      "overrides": {
+        "return": { "after": true },
+        "throw": { "after": true },
+        "case": { "after": true }
+      }
+    }],
+    "linebreak-style": [2, "unix"],
+    "lines-around-comment": [2, {
+      "beforeBlockComment": false,
+      "afterBlockComment": false,
+      "beforeLineComment": false,
+      "allowBlockStart": true,
+      "allowBlockEnd": true
+    }],
+    "max-depth": [2, 5],
+    "max-len": [0, 80, 4],
+    "max-nested-callbacks": [1, 2],
+    "max-params": [1, 3],
+    "new-parens": [2],
+    "newline-after-var": [0],
+    "no-bitwise": [0],
+    "no-cond-assign": [2],
+    "no-console": [2],
+    "no-const-assign": [2],
+    "no-constant-condition": [2],
+    "no-control-regex": [2],
+    "no-debugger": [2],
+    "no-delete-var": [2],
+    "no-dupe-args": [2],
+    "no-dupe-class-members": [2],
+    "no-dupe-keys": [2],
+    "no-duplicate-case": [2],
+    "no-else-return": [0],
+    "no-empty": [2],
+    "no-eq-null": [0],
+    "no-eval": [2],
+    "no-ex-assign": [2],
+    "no-extend-native": [2],
+    "no-extra-bind": [2],
+    "no-extra-boolean-cast": [2],
+    "no-extra-label": [2],
+    "no-extra-parens": [0], // needed for clearer #math eg (a - b) / c
+    "no-extra-semi": [2],
+    "no-fallthrough": [2],
+    "no-floating-decimal": [2],
+    "no-func-assign": [2],
+    "no-implied-eval": [2],
+    "no-implicit-coercion": [2, {
+      "boolean": false,
+      "number": true,
+      "string": true
+    }],
+    "no-implicit-globals": [2],
+    "no-inline-comments": [0],
+    "no-invalid-regexp": [2],
+    "no-irregular-whitespace": [2],
+    "no-iterator": [2],
+    "no-label-var": [2],
+    "no-labels": [2, { "allowLoop": false, "allowSwitch": false }],
+    "no-lone-blocks": [2],
+    "no-lonely-if": [2],
+    "no-loop-func": [2],
+    "no-magic-numbers": [0], // doesn't work well with vis cosmetic constant
+    "no-mixed-requires": [1, false],
+    "no-mixed-spaces-and-tabs": [2, false],
+    "no-multi-spaces": [2, {
+      "exceptions": {
+        "ImportDeclaration": true,
+        "Property": true,
+        "VariableDeclarator": true
+      }
+    }],
+    "no-multi-str": [2],
+    "no-multiple-empty-lines": [2, { "max": 1, "maxEOF": 1 }],
+    "no-native-reassign": [2],
+    "no-negated-condition": [2],
+    "no-negated-in-lhs": [2],
+    "no-nested-ternary": [0],
+    "no-new": [2],
+    "no-new-func": [2],
+    "no-new-object": [2],
+    "no-new-require": [0],
+    "no-new-symbol": [2],
+    "no-new-wrappers": [2],
+    "no-obj-calls": [2],
+    "no-octal": [2],
+    "no-octal-escape": [2],
+    "no-path-concat": [0],
+    "no-process-env": [0],
+    "no-process-exit": [2],
+    "no-proto": [2],
+    "no-redeclare": [2],
+    "no-regex-spaces": [2],
+    "no-restricted-modules": [0],
+    "no-restricted-imports": [0],
+    "no-restricted-syntax": [2,
+      "DebuggerStatement",
+      "LabeledStatement",
+      "WithStatement"
+    ],
+    "no-return-assign": [2, "always"],
+    "no-script-url": [2],
+    "no-self-assign": [2],
+    "no-self-compare": [0],
+    "no-sequences": [2],
+    "no-shadow-restricted-names": [2],
+    "no-spaced-func": [2],
+    "no-sparse-arrays": [2],
+    "no-sync": [0],
+    "no-ternary": [0],
+    "no-this-before-super": [2],
+    "no-throw-literal": [2],
+    "no-trailing-spaces": [2, { "skipBlankLines": false }],
+    "no-undef": [2, { "typeof": true }],
+    "no-undef-init": [2],
+    "no-undefined": [0],
+    "no-underscore-dangle": [0], // __data__ sometimes
+    "no-unexpected-multiline": [2],
+    "no-unmodified-loop-condition": [2],
+    "no-unneeded-ternary": [2],
+    "no-unreachable": [2],
+    "no-unused-expressions": [2],
+    "no-unused-labels": [2],
+    "no-unused-vars": [2, {
+      "vars": "all",
+      "args": "none", // (d, i) pattern d3 func makes difficult to enforce
+      "varsIgnorePattern": "jQuery"
+    }],
+    "no-use-before-define": [0],
+    "no-useless-call": [2],
+    "no-useless-concat": [2],
+    "no-useless-constructor": [2],
+    "no-void": [0],
+    "no-warning-comments": [0, { "terms": ["todo", "fixme", "xxx"], "location": "start" }],
+    "no-with": [2],
+    "no-whitespace-before-property": [2],
+    "object-curly-spacing": [2, "always"],
+    "object-shorthand": [2, "never"],
+    "one-var": [0],
+    "one-var-declaration-per-line": [2, "initializations"],
+    "operator-assignment": [0, "always"],
+    "padded-blocks": [0],
+    "prefer-arrow-callback": [0],
+    "prefer-const": [0],
+    "prefer-reflect": [0],
+    "prefer-rest-params": [0],
+    "prefer-spread": [0],
+    "prefer-template": [0],
+    "quote-props": [2, "as-needed", { "keywords": true }],
+    "radix": [2],
+    "require-yield": [2],
+    "semi": [2],
+    "semi-spacing": [2, { "before": false, "after": true }],
+    "sort-vars": [0],
+    "sort-imports": [0],
+    "space-before-function-paren": [2, { "anonymous": "always", "named": "never" }],
+    "space-before-blocks": [2, { "functions": "always", "keywords": "always" }],
+    "space-in-brackets": [0, "never", {
+      "singleValue": true,
+      "arraysInArrays": false,
+      "arraysInObjects": false,
+      "objectsInArrays": true,
+      "objectsInObjects": true,
+      "propertyName": false
+    }],
+  },
+  // Temporarily not enforced
+  "new-cap": [2], // @TODO more tricky for the moment
+  "newline-per-chained-call": [2, { "ignoreChainWithDepth": 6 }],
+  "no-param-reassign": [0], // turn on once default args supported
+  "no-shadow": [2, { // @TODO more tricky for the moment with eg 'data'
+    "builtinGlobals": false,
+    "hoist": "functions",
+    "allow": ["i", "d"]
+  }],
+  "space-in-parens": [2, "never"],
+  "space-infix-ops": [2],
+  "space-unary-ops": [2, { "words": true, "nonwords": false }],
+  "spaced-comment": [2, "always", { "markers": ["!"] }],
+  "spaced-line-comment": [0, "always"],
+  "strict": [2, "global"],
+  "template-curly-spacing": [2, "never"],
+  "use-isnan": [2],
+  "valid-jsdoc": [0],
+  "valid-typeof": [2],
+  "vars-on-top": [0],
+  "wrap-iife": [2],
+  "wrap-regex": [2],
+  "yield-star-spacing": [2, { "before": false, "after": true }],
+  "yoda": [2, "never", { "exceptRange": true, "onlyEquality": false }]
+}