-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-8835][Streaming] Provide pluggable Congestion Strategies for Receiver-based Streams #9200
Conversation
/cc @tdas and @JoshRosen (the later to issue an 'ok to test' here) |
Pinging @srowen for an 'ok to test'. |
ok to test. |
I think this requires a good design doc for me to make sense of the overall idea, and discuss the design. Its hard to discuss the design in the PR. |
Test build #44516 has finished for PR 9200 at commit
|
98d1cac
to
bc06de2
Compare
Test build #44519 has finished for PR 9200 at commit
|
Folds in the block generator throttling test from ReceiverSuite
THe previous commit (with tests) should pass PR validation though
bc06de2
to
b2dd6b8
Compare
Test build #44520 has finished for PR 9200 at commit
|
Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one. |
The new (destructive) strategies avoid leaving elements in the TCP buffer, leading to breakages at the sender level when this buffer finally drops them.