Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-8835][Streaming] Provide pluggable Congestion Strategies for Receiver-based Streams #9200

Closed

Conversation

huitseeker
Copy link
Contributor

The new (destructive) strategies avoid leaving elements in the TCP buffer, leading to breakages at the sender level when this buffer finally drops them.

@huitseeker huitseeker changed the title [SPARK-8835] Provide pluggable Congestion Strategies for Receiver-based Streams [SPARK-8835][Streaming] Provide pluggable Congestion Strategies for Receiver-based Streams Oct 21, 2015
@huitseeker
Copy link
Contributor Author

/cc @tdas and @JoshRosen (the later to issue an 'ok to test' here)

@huitseeker
Copy link
Contributor Author

Pinging @srowen for an 'ok to test'.
Also, if you're asking yourself why some tests are in "ignore" : the answer is in the commit messages.

@tdas
Copy link
Contributor

tdas commented Oct 28, 2015

ok to test.

@tdas
Copy link
Contributor

tdas commented Oct 28, 2015

I think this requires a good design doc for me to make sense of the overall idea, and discuss the design. Its hard to discuss the design in the PR.

@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44516 has finished for PR 9200 at commit 2e8e5de.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class BernoulliSampler[T: ClassTag](fraction: Double, rng: Random = RandomSampler.newDefaultRNG) extends RandomSampler[T, T]\n

@huitseeker huitseeker force-pushed the feature/CongestionStrategies branch 2 times, most recently from 98d1cac to bc06de2 Compare October 28, 2015 10:43
@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44519 has finished for PR 9200 at commit bc06de2.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class BernoulliSampler[T: ClassTag](fraction: Double,\n

Folds in the block generator throttling test from ReceiverSuite
THe previous commit (with tests) should pass PR validation though
@huitseeker huitseeker force-pushed the feature/CongestionStrategies branch from bc06de2 to b2dd6b8 Compare October 28, 2015 10:56
@SparkQA
Copy link

SparkQA commented Oct 28, 2015

Test build #44520 has finished for PR 9200 at commit b2dd6b8.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * class BernoulliSampler[T: ClassTag](fraction: Double,\n

@rxin
Copy link
Contributor

rxin commented Jun 15, 2016

Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants