[SPARK-10926][CORE] Create WeakReferenceCleaner interface that Contex… #8981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #43240 has finished for PR 8981 at commit
|
mccheah
force-pushed
the
feature/context-cleaner-refactor
branch
from
408bde0 to
624cb3b
Compare
|
jenkins, retest this please |
…tCleaner extends Preparing the way for SPARK-10250 which will introduce other objects that will be cleaned via detecting their being cleaned up.
|
Test build #43399 has finished for PR 8981 at commit
|
|
cc @JoshRosen - patch leading up to the external group by patch. |
|
Test build #43397 has finished for PR 8981 at commit
|
|
@mccheah @JoshRosen does this patch buy us anything if we're not merging #8438? |
|
Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one. |
|
No worries, sorry for not following up - feel free to close this out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the way for SPARK-10250 which will introduce other objects
that will be cleaned via detecting their being cleaned up. In particular, an existing PR - #8438 - has a dependency on this change, but this change was factored out to its own PR to facilitate reviewing: