[SPARK-6236] [core] [wip] caching for blocks over 2GB #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
…e exceptions; placeholders for some tests
Conflicts: core/src/main/scala/org/apache/spark/storage/BlockManager.scala core/src/main/scala/org/apache/spark/storage/BlockObjectWriter.scala core/src/main/scala/org/apache/spark/storage/TachyonStore.scala core/src/test/scala/org/apache/spark/ShuffleSuite.scala streaming/src/main/scala/org/apache/spark/streaming/rdd/WriteAheadLogBackedBlockRDD.scala streaming/src/main/scala/org/apache/spark/streaming/receiver/ReceivedBlockHandler.scala streaming/src/test/scala/org/apache/spark/streaming/ReceivedBlockHandlerSuite.scala
Conflicts: core/src/main/scala/org/apache/spark/util/io/ByteArrayChunkOutputStream.scala core/src/test/scala/org/apache/spark/util/io/ByteArrayChunkOutputStreamSuite.scala network/common/src/main/java/org/apache/spark/network/buffer/BufferTooLargeException.java network/common/src/main/java/org/apache/spark/network/buffer/LargeByteBuffer.java network/common/src/main/java/org/apache/spark/network/buffer/LargeByteBufferHelper.java network/common/src/main/java/org/apache/spark/network/buffer/WrappedLargeByteBuffer.java network/common/src/test/java/org/apache/spark/network/buffer/LargeByteBufferHelperSuite.java network/common/src/test/java/org/apache/spark/network/buffer/WrappedLargeByteBufferSuite.java
Conflicts: core/src/main/scala/org/apache/spark/storage/TachyonBlockManager.scala
|
@tgravescs You can try this out for handling caching for over 2GB. I've tried it out some but haven't really stressed it, interested in your feedback. |
|
Test build #41283 has finished for PR 8320 at commit
|
|
Test build #41293 timed out for PR 8320 at commit |
|
Thanks @squito I'll start looking at it and get somethings running. It will probably be next week by the time I have some results. |
|
Test build #1677 timed out for PR 8320 at commit |
|
Thanks for the pull request. I'm going through a list of pull requests to cut them down since the sheer number is breaking some of the tooling we have. Due to lack of activity on this pull request, I'm going to push a commit to close it. Feel free to reopen it or create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows caching of partitions that are greater than 2GB, and also includes error messages for the other cases where we hit the 2GB limit (replication & shuffle).
This should go on top of #5400, posting for now to get other eyes on it. Also it includes even more giant tests, which is even more pressure to turn these off with some mechanism for slow / integration tests that only run periodically.