[SPARK-7558] Guard against direct uses of FunSuite / FunSuiteLike #6510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewor14
force-pushed
the
extends-funsuite-check
branch
from
6f6d546 to
48874dd
Compare
|
@rxin I couldn't figure out how to make the regex start with a lower case character / include spaces, e.g. |
|
Test build #33780 has finished for PR 6510 at commit
|
|
Test build #33779 has finished for PR 6510 at commit
|
|
Do not merge this yet because it will fail tests in |
added 2 commits
May 29, 2015 18:50
See the in-code comment for an explanation of why this is necessary.
|
Test build #33790 has finished for PR 6510 at commit
|
|
LGTM. |
|
Merged in master. |
andrewor14
pushed a commit
to andrewor14/spark
that referenced
this pull request
Jun 2, 2015
This is a follow-up patch to apache#6441. Author: Andrew Or <[email protected]> Closes apache#6510 from andrewor14/extends-funsuite-check and squashes the following commits: 6618b46 [Andrew Or] Exempt SparkSinkSuite from the FunSuite check 99d02ac [Andrew Or] Merge branch 'master' of github.com:apache/spark into extends-funsuite-check 48874dd [Andrew Or] Guard against direct uses of FunSuite / FunSuiteLike
andrewor14
pushed a commit
to andrewor14/spark
that referenced
this pull request
Jun 3, 2015
This is a follow-up patch to apache#6441. Author: Andrew Or <[email protected]> Closes apache#6510 from andrewor14/extends-funsuite-check and squashes the following commits: 6618b46 [Andrew Or] Exempt SparkSinkSuite from the FunSuite check 99d02ac [Andrew Or] Merge branch 'master' of github.com:apache/spark into extends-funsuite-check 48874dd [Andrew Or] Guard against direct uses of FunSuite / FunSuiteLike Conflicts: scalastyle-config.xml
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
This is a follow-up patch to apache#6441. Author: Andrew Or <[email protected]> Closes apache#6510 from andrewor14/extends-funsuite-check and squashes the following commits: 6618b46 [Andrew Or] Exempt SparkSinkSuite from the FunSuite check 99d02ac [Andrew Or] Merge branch 'master' of github.com:apache/spark into extends-funsuite-check 48874dd [Andrew Or] Guard against direct uses of FunSuite / FunSuiteLike
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
This is a follow-up patch to apache#6441. Author: Andrew Or <[email protected]> Closes apache#6510 from andrewor14/extends-funsuite-check and squashes the following commits: 6618b46 [Andrew Or] Exempt SparkSinkSuite from the FunSuite check 99d02ac [Andrew Or] Merge branch 'master' of github.com:apache/spark into extends-funsuite-check 48874dd [Andrew Or] Guard against direct uses of FunSuite / FunSuiteLike
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up patch to #6441.