Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-1119 and other build improvements #502

Closed
wants to merge 1 commit into from

Conversation

pwendell
Copy link
Contributor

  1. Makes assembly and examples jar naming consistent in maven/sbt.
  2. Updates make-distribution.sh to use Maven and fixes some bugs.
  3. Updates the create-release script to call make-distribution script.

1. Makes assembly and examples jar naming consistent in maven/sbt.
2. Updates make-distribution.sh to use Maven and fixes some bugs.
3. Updates the create-release script to call make-distribution script.
@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14365/

@witgo
Copy link
Contributor

witgo commented Apr 23, 2014

Why change using Maven build? The PR 480 has some relevant changes.

@pwendell
Copy link
Contributor Author

@witgo we've been building releases with maven for several versions of spark due to better stability. We can look at #480 as well...

@pwendell
Copy link
Contributor Author

Okay merged.

asfgit pushed a commit that referenced this pull request Apr 23, 2014
1. Makes assembly and examples jar naming consistent in maven/sbt.
2. Updates make-distribution.sh to use Maven and fixes some bugs.
3. Updates the create-release script to call make-distribution script.

Author: Patrick Wendell <[email protected]>

Closes #502 from pwendell/make-distribution and squashes the following commits:

1a97f0d [Patrick Wendell] SPARK-1119 and other build improvements
(cherry picked from commit cd4ed29)

Signed-off-by: Patrick Wendell <[email protected]>
@asfgit asfgit closed this in cd4ed29 Apr 23, 2014
@witgo
Copy link
Contributor

witgo commented Apr 24, 2014

@berngp @pwendell ,

Whether we can delete the yarn.version, only using hadoop.version.
Like this,

 <profile>
      <id>yarn</id>
      <properties>
        <hadoop.major.version>2</hadoop.major.version>
        <hadoop.version>2.2.0</hadoop.version>
        <protobuf.version>2.5.0</protobuf.version>
      </properties>
      <modules>
        <module>yarn</module>
      </modules>
      <dependencyManagement>
        <dependencies>
          <dependency>
            <groupId>org.apache.hadoop</groupId>
            <artifactId>hadoop-yarn-api</artifactId>
            <version>${hadoop.version}</version>
            <exclusions>
              <exclusion>
                <groupId>asm</groupId>
                <artifactId>asm</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.ow2.asm</groupId>
                <artifactId>asm</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.jboss.netty</groupId>
                <artifactId>netty</artifactId>
              </exclusion>
            </exclusions>
          </dependency>
          <dependency>
            <groupId>org.apache.hadoop</groupId>
            <artifactId>hadoop-yarn-common</artifactId>
            <version>${hadoop.version}</version>
            <exclusions>
              <exclusion>
                <groupId>asm</groupId>
                <artifactId>asm</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.ow2.asm</groupId>
                <artifactId>asm</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.jboss.netty</groupId>
                <artifactId>netty</artifactId>
              </exclusion>
            </exclusions>
          </dependency>
          <dependency>
            <groupId>org.apache.hadoop</groupId>
            <artifactId>hadoop-yarn-client</artifactId>
            <version>${hadoop.version}</version>
            <exclusions>
              <exclusion>
                <groupId>asm</groupId>
                <artifactId>asm</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.ow2.asm</groupId>
                <artifactId>asm</artifactId>
              </exclusion>
              <exclusion>
                <groupId>org.jboss.netty</groupId>
                <artifactId>netty</artifactId>
              </exclusion>
            </exclusions>
          </dependency>
        </dependencies>
      </dependencyManagement>
    </profile>

will cause any problems?

@berngp
Copy link
Contributor

berngp commented Apr 24, 2014

Yes it will, not every one uses the same version of HDFS vs YARN.

On Wednesday, April 23, 2014, Li Guoqiang [email protected] wrote:

@berngp https://github.com/berngp @pwendellhttps://github.com/pwendell,
Whether we can delete the yarn.version, only using hadoop.version. This
will cause any problems?


Reply to this email directly or view it on GitHubhttps://github.com//pull/502#issuecomment-41237973
.

@witgo
Copy link
Contributor

witgo commented Apr 24, 2014

@berngp
Most of the people uses the same version of HDFS vs YARN.
We can be so

   <hadoop.version>1.0.4</hadoop.version>
   <yarn.version>${hadoop.version}</yarn.version>
 <profile>
      <id>yarn-alpha</id>
      <properties>
        <hadoop.major.version>2</hadoop.major.version>   
        <hadoop.version>0.23.7</hadoop.version>
      </properties>
      <modules>
        <module>yarn</module>
      </modules>
      <dependencyManagement>
        <dependencies>
          <dependency>
            <groupId>org.apache.hadoop</groupId>
            <artifactId>hadoop-yarn-api</artifactId>
            <version>${yarn.version}</version>
          </dependency>
          <dependency>
            <groupId>org.apache.hadoop</groupId>
            <artifactId>hadoop-yarn-common</artifactId>
            <version>${yarn.version}</version>
          </dependency>
          <dependency>
            <groupId>org.apache.hadoop</groupId>
            <artifactId>hadoop-yarn-client</artifactId>
            <version>${yarn.version}</version>
          </dependency>
        </dependencies>
      </dependencyManagement>
    </profile>

Most of the people use mvn -Pyarn -Dhadoop.version=2.3.0 -DskipTests clean package.
Others usemvn -Pyarn-alpha -Dhadoop.version=2.3.0 -DskipTests -Dyarn.version=0.23.9 clean package.

@berngp
Copy link
Contributor

berngp commented Apr 24, 2014

Makes sense to me.

On Wednesday, April 23, 2014, Li Guoqiang [email protected] wrote:

@berngp https://github.com/berngp
Most of the people uses the same version of HDFS vs YARN.
We can be so

<hadoop.version>1.0.4</hadoop.version>
<yarn.version>${hadoop.version}</yarn.version>

yarn-alpha 2 0.23.7 yarn org.apache.hadoop hadoop-yarn-api ${yarn.version} org.apache.hadoop hadoop-yarn-common ${yarn.version} org.apache.hadoop hadoop-yarn-client ${yarn.version}

Most of the people use mvn -Pyarn -Dhadoop.version=2.3.0 -DskipTests
clean package.
Others usemvn -Pyarn -Dhadoop.version=2.3.0 -DskipTests
-Dyarn.version=0.23.9 clean package.


Reply to this email directly or view it on GitHubhttps://github.com//pull/502#issuecomment-41239453
.

pwendell added a commit to pwendell/spark that referenced this pull request May 12, 2014
Remove Hadoop object cloning and warn users making Hadoop RDD's.

The code introduced in apache#359 used Hadoop's WritableUtils.clone() to
duplicate objects when reading from Hadoop files. Some users have
reported exceptions when cloning data in various file formats,
including Avro and another custom format.

This patch removes that functionality to ensure stability for the
0.9 release. Instead, it puts a clear warning in the documentation
that copying may be necessary for Hadoop data sets.
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
1. Makes assembly and examples jar naming consistent in maven/sbt.
2. Updates make-distribution.sh to use Maven and fixes some bugs.
3. Updates the create-release script to call make-distribution script.

Author: Patrick Wendell <[email protected]>

Closes apache#502 from pwendell/make-distribution and squashes the following commits:

1a97f0d [Patrick Wendell] SPARK-1119 and other build improvements
andrewor14 pushed a commit to andrewor14/spark that referenced this pull request Jan 8, 2015
Remove Hadoop object cloning and warn users making Hadoop RDD's.

The code introduced in apache#359 used Hadoop's WritableUtils.clone() to
duplicate objects when reading from Hadoop files. Some users have
reported exceptions when cloning data in various file formats,
including Avro and another custom format.

This patch removes that functionality to ensure stability for the
0.9 release. Instead, it puts a clear warning in the documentation
that copying may be necessary for Hadoop data sets.
(cherry picked from commit c319617)

Conflicts:

	core/src/main/scala/org/apache/spark/api/java/JavaSparkContext.scala
markhamstra pushed a commit to markhamstra/spark that referenced this pull request Nov 7, 2017
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
…pache#502)

Add periodic jobs for ansible/packer/docker-machine/manageiq
against OpenStack Stein release.

Related: theopenlab/openlab#231
arjunshroff pushed a commit to arjunshroff/spark that referenced this pull request Nov 24, 2020
HyukjinKwon pushed a commit that referenced this pull request Jun 8, 2022
### What changes were proposed in this pull request?
This pr aims upgrade scala-maven-plugin to 4.6.2

### Why are the changes needed?
This version brings some bug fix related to `Incremental compile`, although it seems that Spark has not encountered these issue:

- [Fix incremental compiler not being able to find JDK classes when compiler macros with Java 11, close #502](davidB/scala-maven-plugin#608)
- [Fix incremental compilation on Java 11+, close #600](davidB/scala-maven-plugin#609)

all changes as follows:

- davidB/scala-maven-plugin@4.6.1...4.6.2

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Pass Github Actions

Closes #36800 from LuciferYang/scala-maven-plugin-462.

Authored-by: yangjie01 <[email protected]>
Signed-off-by: Hyukjin Kwon <[email protected]>
RolatZhang pushed a commit to RolatZhang/spark that referenced this pull request Aug 15, 2022
KE-35596 Update jackson & tomcat version for vulnerability issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants