[SPARK-50478][SQL] Fix StringType matching #49043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefankandic
reviewed
Dec 3, 2024
| @@ -40,8 +40,8 @@ private[sql] object UpCastRule { | |||
| case (DateType, TimestampNTZType) => true | |||
| case (TimestampNTZType, TimestampType) => true | |||
| case (TimestampType, TimestampNTZType) => true | |||
| case (_: AtomicType, StringType) => true | |||
| case (_: CalendarIntervalType, StringType) => true | |||
| case (_: AtomicType, _: StringType) => true | |||
There was a problem hiding this comment.
can we add some tests for upcast here?
There was a problem hiding this comment.
Also please make sure that this does not allow casting from int to string directly by calling cast. In general by standard we should do cast (value as string) collate collation, but it is a good catch that we need to allow this transition in other operations.
jovanm-db
changed the title
|
Please remove draft and add [SQL] component to the title of the PR. |
jovanm-db
changed the title
MaxGekk
approved these changes
Dec 6, 2024
sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeWriteCompatibilitySuite.scala
Outdated
Show resolved
Hide resolved
…eWriteCompatibilitySuite.scala
|
+1, LGTM. Merging to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In
canUpCastmethod inUpCastRule.scalawe match againstStringType, which does not match collated string, as opposed to matching_: StringType. Similarly, inneedsTimeZonemethod inCast.scalait is matched against non collated StringType.Why are the changes needed?
Upcasting to collated strings was disabled even when upcasting to non collated strings was not. Likewise, casting from timestamp to collated string did not need time zone.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Test added in
DataTypeWriteCompatibilitySuite.scalaandCastSuiteBase.scala.Was this patch authored or co-authored using generative AI tooling?
No.