remove unnecessary brace and semicolon in 'putBlockInfo.synchronize' block #411
Conversation
| @@ -678,7 +678,7 @@ private[spark] class BlockManager( | |||
| case ArrayBufferValues(array) => | |||
| tachyonStore.putValues(blockId, array, level, false) | |||
| case ByteBufferValues(bytes) => { | |||
There was a problem hiding this comment.
can you remove the { and } here also? thanks
There was a problem hiding this comment.
it seems that the whole code in block 'putBlockInfo.synchronized' are in the same style with brace unnecessary...
There was a problem hiding this comment.
if you don't mind changing those that'd be great!
There was a problem hiding this comment.
all are removed i think ... please review & test
|
Jenkins, add to whitelist. |
|
Can one of the admins verify this patch? |
|
Jenkins, add to whitelist. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build triggered. |
CrazyJvm
changed the title
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
Thanks. I've merged this |
…block delete semicolon Author: Chen Chao <[email protected]> Closes #411 from CrazyJvm/patch-5 and squashes the following commits: 72333a3 [Chen Chao] remove unnecessary brace de5d9a7 [Chen Chao] style fix (cherry picked from commit 016a877) Signed-off-by: Reynold Xin <[email protected]>
Improved logic of finding new files in FileInputDStream Earlier, if HDFS has a hiccup and reports a existence of a new file (mod time T sec) at time T + 1 sec, then fileStream could have missed that file. With this change, it should be able to find files that are delayed by up to <batch size> seconds. That is, even if file is reported at T + <batch time> sec, file stream should be able to catch it. The new logic, at a high level, is as follows. It keeps track of the new files it found in the previous interval and mod time of the oldest of those files (lets call it X). Then in the current interval, it will ignore those files that were seen in the previous interval and those which have mod time older than X. So if a new file gets reported by HDFS that in the current interval, but has mod time in the previous interval, it will be considered. However, if the mod time earlier than the previous interval (that is, earlier than X), they will be ignored. This is the current limitation, and future version would improve this behavior further. Also reduced line lengths in DStream to <=100 chars.
…block delete semicolon Author: Chen Chao <[email protected]> Closes apache#411 from CrazyJvm/patch-5 and squashes the following commits: 72333a3 [Chen Chao] remove unnecessary brace de5d9a7 [Chen Chao] style fix
- Add OS_USER_DOMAIN_ID and OS_PROJECT_DOMAIN_ID for Mitaka jobs - Change the AUTH_URL by adding '/v3' postfix for M+ jobs Closes: theopenlab/openlab#160
delete semicolon