Remove extra semicolon in import statement and unused import in ApplicationMaster #358
Conversation
…cationMaster.scala
|
bothers me too. will merge once jenkins is happy. |
|
Merged build triggered. |
|
Merged build started. |
|
Meta question - all of the unused imports can be zapped in one go with an IDE and semicolons too. Is that worth one big PR here? |
|
It might be worth it. But be careful sometimes IDE gives you false signals. Also for the imports to conform to Spark's coding standard, we need @aarondav's import organizer plugin for IntelliJ. |
|
@srowen there has been PR (I think I sent it) to remove unnecessary semicolons and imports in Scala before and AFAIK we have removed most of them. Probably the best way to have some kind of check executed by Jenkins in addition to style check. |
|
Merged build finished. |
|
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/13882/ |
|
Seems like Jenkins had build error related to some PySpark file parsing. |
|
Jenkins, retest this please. |
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
|
ok i've merged this. thanks |
|
Thx! |
…cationMaster Small nit cleanup to remove extra semicolon and unused import in Yarn's stable ApplicationMaster (it bothers me every time I saw it) Author: Henry Saputra <[email protected]> Closes apache#358 from hsaputra/nitcleanup_removesemicolon_import_applicationmaster and squashes the following commits: bffb685 [Henry Saputra] Remove extra semicolon in import statement and unused import in ApplicationMaster.scala
* Fix manageiq job against Mitaka devstack
…e#358) * KY-895, Spark driver pod cleanup when application is completed * KY-895, release 3.1.1-kylin-4.x-r42-xuanwu
…#528) * KY-895, Spark driver pod cleanup when application is completed (apache#358) * KY-895, Spark driver pod cleanup when application is completed * KY-895, release 3.1.1-kylin-4.x-r42-xuanwu * KY-895, add config KUBERNETES_DELETE_DRIVER (apache#376) Co-authored-by: Feng Zhu <[email protected]>
* KE-39980 configMap Binds the KE pod * minor fix dockerfile java version and host user (apache#510) * KY-895 Spark driver pod cleanup when application is completed (apache#528) * KY-895, Spark driver pod cleanup when application is completed (apache#358) * KY-895, Spark driver pod cleanup when application is completed * KY-895, release 3.1.1-kylin-4.x-r42-xuanwu * KY-895, add config KUBERNETES_DELETE_DRIVER (apache#376) Co-authored-by: Feng Zhu <[email protected]> --------- Co-authored-by: Jiawei Li <[email protected]> Co-authored-by: Zhiting Guo <[email protected]> Co-authored-by: Feng Zhu <[email protected]>
Small nit cleanup to remove extra semicolon and unused import in Yarn's stable ApplicationMaster (it bothers me every time I saw it)