Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE]codeStyle: uniform ConcurrentHashMap define in StorageLevel.scala with other places #2793

Closed

Conversation

liyezhang556520
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Oct 14, 2014

QA tests have started for PR 2793 at commit 5884735.

  • This patch merges cleanly.

@srowen
Copy link
Member

srowen commented Oct 14, 2014

This also seems at about the level of too trivial to bother with. It replaces a single fully qualified class name with an import, which doesn't even simplify.

@liyezhang556520
Copy link
Contributor Author

But what about other places use ConcurrentHashMap, seems all of them are using import, should not they be unified?

@srowen
Copy link
Member

srowen commented Oct 14, 2014

That's not what the PR does though. How many occurrences are there to change?

@liyezhang556520
Copy link
Contributor Author

Well, only here use a single fully qualified class name, and other places use import. like line 25 in SortShuffleManager.scala, line 602 in Utils.scala, etc.

@SparkQA
Copy link

SparkQA commented Oct 14, 2014

QA tests have finished for PR 2793 at commit 5884735.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21720/
Test PASSed.

@pwendell
Copy link
Contributor

meh - seems fine to me as a minor cleanup. Jenkins, test this please. If it passes we can merge it.

@SparkQA
Copy link

SparkQA commented Nov 19, 2014

Test build #23602 has started for PR 2793 at commit 5884735.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 19, 2014

Test build #23602 has finished for PR 2793 at commit 5884735.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23602/
Test PASSed.

@liyezhang556520
Copy link
Contributor Author

@pwendell , can this be merged?

@JoshRosen
Copy link
Contributor

Meh, I guess we might as well merge this if it still passes tests.

Jenkins, retest this please.

@liyezhang556520
Copy link
Contributor Author

Jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Dec 11, 2014

Test build #24344 has started for PR 2793 at commit 5884735.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 11, 2014

Test build #24344 has finished for PR 2793 at commit 5884735.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24344/
Test PASSed.

@JoshRosen
Copy link
Contributor

Alright, I've merged this into master. Thanks!

@asfgit asfgit closed this in 57d37f9 Dec 11, 2014
@liyezhang556520 liyezhang556520 deleted the uniformHashMap branch December 29, 2014 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants